Skip to content

fix(openaicompat): handle cerebras/glm-4.6 thinking #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(openaicompat): handle cerebras/glm-4.6 thinking #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions providers/openaicompat/language_model_hooks.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,9 @@ func ExtraContentFunc(choice openaisdk.ChatCompletionChoice) []fantasy.Content {
if err != nil {
return content
}
if reasoningData.ReasoningContent != "" {
if reasoning := reasoningData.GetReasoning(); reasoning != "" {
content = append(content, fantasy.ReasoningContent{
Text: reasoningData.ReasoningContent,
Text: reasoning,
})
}
return content
Expand Down Expand Up @@ -110,11 +110,11 @@ func StreamExtraFunc(chunk openaisdk.ChatCompletionChunk, yield func(fantasy.Str
Delta: reasoningContent,
})
}
if reasoningData.ReasoningContent != "" {
if reasoning := reasoningData.GetReasoning(); reasoning != "" {
if !reasoningStarted {
ctx[reasoningStartedCtx] = true
}
return ctx, emitEvent(reasoningData.ReasoningContent)
return ctx, emitEvent(reasoning)
}
if reasoningStarted && (choice.Delta.Content != "" || len(choice.Delta.ToolCalls) > 0) {
ctx[reasoningStartedCtx] = false
Expand Down
13 changes: 13 additions & 0 deletions providers/openaicompat/provider_options.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,21 @@ type ProviderOptions struct {
}

// ReasoningData represents reasoning data for OpenAI-compatible provider.
// Different providers may use different field names (reasoning_content vs reasoning).
type ReasoningData struct {
// Most common
ReasoningContent string `json:"reasoning_content"`
// So far, only used by Cerebras specifically for GLM 4.6
Reasoning string `json:"reasoning"`
}

// GetReasoning returns the reasoning content whether it's in `reasoning` or
// `reasoning_content` JSON fields.
func (r *ReasoningData) GetReasoning() string {
if r.ReasoningContent != "" {
return r.ReasoningContent
}
return r.Reasoning
}

// Options implements the ProviderOptions interface.
Expand Down
Loading