fix: manually load font file or fonts dirs when use resvg-go #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isabelroses
reviewed
Apr 19, 2024
| switch runtime.GOOS { | ||
| case "windows": | ||
| DefaultFontsDirectories = []string{filepath.Join(os.Getenv("windir"), "Fonts")} | ||
| case "linux": |
Contributor
There was a problem hiding this comment.
why not make this (the linux case) the default case then it should also be able to handle BSD systems too (at least in theory)
Author
There was a problem hiding this comment.
if librsvg was installed, it won't meet this case.it easy for linux / BSD systems user to install librsvg
Contributor
There was a problem hiding this comment.
I wonder if it would be better to do this at build time, rather than runtime? I.e. have font_linux.go, font_darwin.go, font_windows.go files, with the //go:build directives.
Contributor
|
Thank you for this PR, it's very much appreciated ❤️ |
|
Appreciated, yet never merged. |
Wangnov
pushed a commit
to Wangnov/freeze
that referenced
this pull request
Dec 24, 2025
This commit adds support for loading system fonts when converting SVG to PNG, which fixes the issue where CJK and other non-ASCII characters are not rendered correctly in PNG output. Changes: - Add platform-specific font directory definitions using build tags: - dirs_darwin.go: macOS system font directories - dirs_linux.go: Linux system font directories - dirs_windows.go: Windows system font directories - dirs_other.go: fallback for unsupported platforms - Modify png.go to load fonts from system directories - Add FREEZE_NO_SYSTEM_FONTS=1 env var to skip system font loading - Warn when font directories fail to load (visible at default log level) - Handle os.UserHomeDir() errors properly Performance note: Font directories are scanned on each conversion. For better performance, set FREEZE_NO_SYSTEM_FONTS=1, use SVG output, or install rsvg-convert. Fixes charmbracelet#93 Related to charmbracelet#83
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #80