[18.0][MIG] stock_product_variant_mto: Migration to 18.0 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define route_ids as computed on the product variant, in order to reuse route_ids from its template and add or remove MTO route according to the setting on the variant. In case MTO route is changed on the template, it must reset any variant specific setting.
chaule97
force-pushed
the
18.0-mig-stock_product_variant_mto
branch
from
eb0843c to
8619cbe
Compare
thienvh332
reviewed
Jan 3, 2025
| self.assertVariantsMTO(pens) | ||
| # Disable mto route for black_pen | ||
| self.toggle_is_mto(black_pen) | ||
| self.assertVariantsNotMTO(black_pen) | ||
| self.assertVariantsMTO(blue_pen | green_pen | red_pen) | ||
| # Disable mto route on the template, reset is_mto on variants | ||
| self.remove_route(pen_template, self.mto_route) | ||
| with self.assertLogs(level="WARNING"): |
There was a problem hiding this comment.
It is recommended to explicitly add loggers to avoid error logs from other locations being missed.
| @@ -24,14 +26,16 @@ def test_variants_mto(self): | |||
| self.assertVariantsMTO(black_pen | blue_pen) | |||
| self.assertVariantsNotMTO(red_pen | green_pen) | |||
| # Now enable the mto route for the template, all variants get is_mto = True | |||
| self.add_route(pen_template, self.mto_route) | |||
| with self.assertLogs(level="WARNING"): | |||
| @@ -44,7 +48,8 @@ def test_template_routes_updated(self): | |||
| black_pen = self.black_pen | |||
| self.assertVariantsNotMTO(pens) | |||
| # If template is set to MTO, all variants are updated | |||
| self.add_route(pen_template, self.mto_route) | |||
| with self.assertLogs(level="WARNING"): | |||
| # Enable mto route on the template, raise warning as is_mto is reset on variants | ||
| with self.assertLogs(onchange_logger) as log: | ||
| with self.assertLogs(level="WARNING") as log_catcher: |
chaule97
force-pushed
the
18.0-mig-stock_product_variant_mto
branch
2 times, most recently
from
b1cc181 to
c44fab9
Compare
thienvh332
approved these changes
Jan 6, 2025
| # Enable unrelated route does not raise warning nor reset | ||
| random_route = self.mto_route.create({"name": "loutourout de la vit"}) | ||
| with self.assertLogs(onchange_logger) as log: | ||
| with self.assertLogs("odoo.tests.form.onchange") as log_catcher: |
There was a problem hiding this comment.
odoo.tests.form.onchange is reused many times. Optimize it by naming the variable eg onchange_logger
chaule97
force-pushed
the
18.0-mig-stock_product_variant_mto
branch
3 times, most recently
from
4889262 to
d557475
Compare
chaule97
force-pushed
the
18.0-mig-stock_product_variant_mto
branch
from
d557475 to
bbc05c8
Compare
chaule97
force-pushed
the
18.0-mig-stock_product_variant_mto
branch
from
bbc05c8 to
5e0cc07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
route_idsstored=Truebecause this code made errorNon-stored field product.product.route_ids cannot be searched.