Add new caliptra crypto primitives for SPDM #265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds new cryptographic primitives to the Caliptra API to support SPDM (Security Protocol and Data Model) functionality. The changes introduce three new crypto modules that provide essential cryptographic operations needed for secure device communication.
Key changes include:
- Addition of ECDH (Elliptic Curve Diffie-Hellman) key exchange functionality
- Implementation of HMAC and HKDF (HMAC-based Key Derivation Function) operations
- Addition of cryptographic key import capabilities
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| runtime/userspace/api/caliptra-api/src/crypto/mod.rs | Exports the three new crypto modules (ecdh, hmac, import) |
| runtime/userspace/api/caliptra-api/src/crypto/ecdh.rs | Implements ECDH key generation and exchange completion |
| runtime/userspace/api/caliptra-api/src/crypto/hmac.rs | Provides HMAC, HKDF extract, and HKDF expand operations |
| runtime/userspace/api/caliptra-api/src/crypto/import.rs | Enables importing cryptographic keys with specified usage patterns |
swenson
force-pushed
the
spdm-key-exchange-crypto
branch
from
c5060eb to
2de3d2b
Compare
swenson
added a commit
that referenced
this pull request
Jul 15, 2025
The crypto is in #265 The transcripts are going to be complex, so I'll add those in a separate PR as well.
swenson
force-pushed
the
spdm-key-exchange-crypto
branch
3 times, most recently
from
0fa3eb1 to
6c78879
Compare
Add ECDH, import, and HMAC tests Switch back to unaligned mem; move len subtract to after check
swenson
force-pushed
the
spdm-key-exchange-crypto
branch
from
6c78879 to
e056e63
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.