lowRISC change bundle 6 #812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This register is W1C and has two fields, so we need to write 0x3 to clear it.
This test tries to ask for a transition with a bogus token. It checks that the dut replies with an error (which it does!), but then checks that the transition didn't work, by checking that the current state hasn't changed. That isn't quite right: lc_ctrl may also change state to POST_TRANSITION (whether or not the transition succeeded). This is documented in the repository that defines the IP: https://opentitan.org/book/hw/ip/lc_ctrl/doc/theory_of_operation.html#post-transition-handling Change the test so that it allows either behaviour.
|
Promote pipeline triggered as 20251010.10. |
…p and hash after successful run
…p and hash after successful run
…p and hash after successful run
ekarabu
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.