Skip to content
This repository was archived by the owner on Aug 20, 2024. It is now read-only.

[WIP] build.sc: fix NoSuchElementException: empty.head #2605

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

vowstar
Copy link
Member

@vowstar vowstar commented Feb 23, 2023

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you update the FIRRTL spec to include every new feature/behavior?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

API Impact

Backend Code Generation Impact

Desired Merge Strategy

Release Notes

  • Use regular expressions to get version strings more rigorously
  • Add version discriminant function, you can compare version size
  • Correct the version comparison of antlr under special conditions
  • Improve the version comparison of protoc

Closes: #2604

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (1.2.x, 1.3.0, 1.4.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

- Use regular expressions to get version strings more rigorously
- Add version discriminant function, you can compare version size
- Correct the version comparison of antlr under special conditions
- Improve the version comparison of protoc

Closes: chipsalliance#2604
Signed-off-by: Huang Rui <[email protected]>
@CLAassistant
Copy link

CLAassistant commented Feb 23, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@sequencer sequencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll merge this after CI passed. However SFC is going to be deprecated, there is another in source minimal SFC in the chisel repo. After chisel5 finally landing to master branch, this commit should be cherry-pick to chisel master.

@sequencer sequencer enabled auto-merge (squash) February 23, 2023 07:09
vowstar added a commit to vowstar/playground that referenced this pull request Feb 23, 2023
@sequencer sequencer merged commit 6a999e3 into chipsalliance:master Feb 23, 2023
vowstar added a commit to vowstar/playground that referenced this pull request Feb 23, 2023
vowstar added a commit to vowstar/playground that referenced this pull request Feb 23, 2023
@seldridge
Copy link
Member

@vowstar: I pulled this commit into Chisel3 as part of the MFC migration here: chipsalliance/chisel#2982

Would you be able to also sign the CLA on the Chisel repository? Thanks!

@vowstar
Copy link
Member Author

vowstar commented Feb 25, 2023

@vowstar: I pulled this commit into Chisel3 as part of the MFC migration here: chipsalliance/chisel3#2982

Would you be able to also sign the CLA on the Chisel repository? Thanks!

Thanks for the reminder, I have signed the CLA on the Chisel repository

@seldridge
Copy link
Member

Awesome. Thanks, again!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build.sc: firrtlCrossModule.antlr4Path java.util.NoSuchElementException: empty.head
4 participants