CI checks to check for missing downgrade updates #6661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanefi
changed the title
hanefi
force-pushed
the
downgrade-checks
branch
from
c91a676
to
b1a2666
Compare
|
There is a small problem with grep on CI machines. It is busybox grep that does not accept long parameter names. Hence I needed to install GNU grep in the CI images. See citusdata/the-process#105 |
JelteF
reviewed
Feb 7, 2023
hanefi
added a commit
to citusdata/the-process
that referenced
this pull request
Feb 7, 2023
When we add some scripts to run in CI, it is a nice idea to use long argument names. However, the busybox grep binary in our images do not support long argument names, and hence we install GNU grep. Used in: citusdata/citus#6661
JelteF
reviewed
Feb 7, 2023
hanefi
force-pushed
the
downgrade-checks
branch
from
b1a2666
to
0eb7820
Compare
|
I used to base these changes here on top of #6637. I now rebased on top of main and changed the target branch of the PR accordingly. |
hanefi
force-pushed
the
downgrade-checks
branch
from
0eb7820
to
95274d2
Compare
JelteF
approved these changes
Feb 15, 2023
Comment on lines
+10
to
+11
| upgrade_files=$(git diff --name-only origin/main | { grep "src/backend/distributed/sql/citus--.*sql" || exit 0 ; }) | ||
| downgrade_files=$(git diff --name-only origin/main | { grep "src/backend/distributed/sql/downgrades/citus--.*sql" || exit 0 ; }) |
There was a problem hiding this comment.
This is only doing this check for citus upgrade files, not for columnar ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A branch that touches a set of upgrade scripts is also expected to touch corresponding downgrade scripts as well. To ensure that I introduce a new CI script. If this script fails, read the output and make sure you update the downgrade scripts in the printed list.