Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install grep in stylechecker image #105

Merged
merged 2 commits into from
Feb 7, 2023
Merged

Install grep in stylechecker image #105

merged 2 commits into from
Feb 7, 2023

Conversation

hanefi
Copy link
Member

@hanefi hanefi commented Jan 27, 2023 •
edited
Loading

When we add some scripts to run in CI, it is a nice idea to use long argument names. However, the busybox grep binary in our images do not support long argument names, and hence we install GNU grep.

Used in: citusdata/citus#6661

@hanefi hanefi mentioned this pull request Jan 27, 2023
Merged
JelteF
JelteF approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@JelteF JelteF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a link to the citus PR that depends on the description of this PR?

@hanefi hanefi merged commit a40ca0b into master Feb 7, 2023
@hanefi hanefi deleted the add-grep-to-stylechecker branch February 7, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelteF JelteF JelteF approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanefi @JelteF