Skip to content

Muness/issue169 #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
muness merged 3 commits into from
Mar 20, 2025
Merged

Muness/issue169 #170

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2059c33
Add support for local ICS files in calendar settings
muness Mar 19, 2025
e136203
The vdir support makes this unnecessary. Will update settings languag…
muness Mar 20, 2025
10e5b82
Update calendar type settings description and naming for ICS file sup…
muness Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/settings/ICSSettingsTab.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,10 +275,10 @@ class SettingsModal extends Modal {

const calendarTypeSetting = new Setting(settingDiv)
.setName('Calendar Type')
.setDesc('Select the type of calendar (Remote URL or vdir)')
.setDesc('Select the type of calendar (Remote URL or Vault Folder with ICS files, maintained manually or via automation like vdirsyncer)')
.addDropdown(dropdown => {
dropdown.addOption('remote', 'Remote URL');
dropdown.addOption('vdir', 'vdir');
dropdown.addOption('vdir', 'Folder with ICS files');
dropdown.setValue(this.calendarType)
.onChange(value => {
this.calendarType = value as 'remote' | 'vdir';
Expand All @@ -294,7 +294,8 @@ class SettingsModal extends Modal {
settingDiv.querySelectorAll('.url-setting').forEach(el => el.remove());

let urlSetting = new Setting(urlSettingDiv)
.setName(this.calendarType === 'vdir' ? 'Directory' : 'Calendar URL');
.setDesc(this.calendarType === 'vdir' ? 'Select the folder containing ICS files. Must be in the current Obdidian Vault and have at least one ics.' : 'Enter the URL of the calendar')
.setName(this.calendarType === 'vdir' ? 'Vault Folder' : 'Calendar URL');
urlSetting.settingEl.addClass('url-setting');

if (this.calendarType === 'vdir') {
Expand Down