feat: implement flexible date input for getEvents() method #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add DateNormalizer class to handle string, moment, and Date object inputs - Fix issue where moment objects passed to getEvents() weren't being processed - Extract date normalization logic from icalUtils.ts for better separation of concerns - Add comprehensive test coverage for DateNormalizer (19 test cases) - Maintain backward compatibility while enabling mixed date input types - Resolve recurring events not appearing when using Templater with moment objects Resolves issue where Meeting 2 style recurring events weren't showing up when Templater code passed moment objects instead of formatted strings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #181 where a user was using moment objects in their template. I think that should work for a more friendly API.