Skip to content

Conversation

@muness
Copy link
Member

@muness muness commented Sep 23, 2025

This pull request updates the version to 1.11.0 and sets the minimum Obsidian version to 1.9.12.

Summary by CodeRabbit

  • Chores
    • Updated application version to 1.11.0.
    • Synchronized versioning across the app for consistency.
    • Refreshed internal version compatibility mapping to include the new release.
    • No functional changes or user-facing behavior updates in this release.

@coderabbitai
Copy link

coderabbitai bot commented Sep 23, 2025

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

Version numbers updated from 1.10.3 to 1.11.0 in manifest.json and package.json. versions.json gains a new mapping entry "1.11.0": "1.9.12" with preceding comma adjustment. No other fields or logic changed.

Changes

Cohort / File(s) Summary of Changes
Version bump metadata
manifest.json, package.json
Incremented version fields from 1.10.3 to 1.11.0.
Version mapping
versions.json
Added mapping "1.11.0": "1.9.12"; added trailing comma to previous "1.10.3" entry.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

I thump the ground—new version glow,
From 1.10.3 to 1.11.0 we go.
A tidy map, a comma placed,
The carrots of release well-laced.
Patch by patch, I hop with glee—
Ship it swift, then time for tea. 🥕🐇

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The PR title "Release 1.11.0" accurately and concisely summarizes the main change — the package/manifest version bump to 1.11.0 and the added 1.11.0 entry in versions.json — and is clear and appropriate for a release PR.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

Comment @coderabbitai help to get the list of available commands and usage tips.

@muness muness merged commit 4952f40 into master Sep 23, 2025
@muness muness deleted the release/1.11.0 branch September 23, 2025 01:46
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
versions.json (1)

12-14: Typo in historical mapping: ".15.0" should be "0.15.0".
Not part of this bump, but it can break tooling that parses semver. Safe, backportable fix:

-  "0.9.14": ".15.0",
+  "0.9.14": "0.15.0",
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b17750b and af72ac6.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (3)
  • manifest.json (1 hunks)
  • package.json (1 hunks)
  • versions.json (1 hunks)
🔇 Additional comments (4)
package.json (2)

3-3: Version bump to 1.11.0 — LGTM.
Matches manifest.json; no functional deltas.


24-38: Align devDependencies: bump obsidian and reconcile Jest/ts-jest

  • manifest.minAppVersion and versions.json are aligned (script output: OK: versions aligned).
  • package.json still lists "obsidian": "1.7.2" — bump to match manifest:
-    "obsidian": "1.7.2",
+    "obsidian": "^1.9.12",

(File: package.json → devDependencies)

  • Jest (^30.1.1) vs ts-jest (^29.4.1): ts-jest v29 warns that Jest 30 is untested and ts-jest’s major follows Jest. ts-jest v30 is not generally available — either pin Jest to ^29.x now or upgrade ts-jest to a v30 release when it exists, then run the test suite to verify. Do not silence ts-jest’s version checker unless you accept the risk.
versions.json (1)

67-69: Added mapping for 1.11.0 → 1.9.12 — LGTM.
Consistent with manifest.minAppVersion and release intent.

Please run the provided cross-file check script (see package.json comment) to ensure future bumps stay in lockstep.

manifest.json (1)

4-5: Version 1.11.0 with minAppVersion 1.9.12 — LGTM.
Matches versions.json mapping.

Given the new minimum, confirm no API usage requires a higher Obsidian core, and consider updating the devDependency "obsidian" types to ≥1.9 for compile-time coverage (see package.json comment).

@coderabbitai coderabbitai bot mentioned this pull request Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants