-
-
Notifications
You must be signed in to change notification settings - Fork 36
Release 1.11.0 #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.11.0 #194
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the WalkthroughVersion numbers updated from 1.10.3 to 1.11.0 in manifest.json and package.json. versions.json gains a new mapping entry "1.11.0": "1.9.12" with preceding comma adjustment. No other fields or logic changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
versions.json (1)
12-14: Typo in historical mapping: ".15.0" should be "0.15.0".
Not part of this bump, but it can break tooling that parses semver. Safe, backportable fix:- "0.9.14": ".15.0", + "0.9.14": "0.15.0",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (3)
manifest.json(1 hunks)package.json(1 hunks)versions.json(1 hunks)
🔇 Additional comments (4)
package.json (2)
3-3: Version bump to 1.11.0 — LGTM.
Matches manifest.json; no functional deltas.
24-38: Align devDependencies: bump obsidian and reconcile Jest/ts-jest
- manifest.minAppVersion and versions.json are aligned (script output: OK: versions aligned).
- package.json still lists "obsidian": "1.7.2" — bump to match manifest:
- "obsidian": "1.7.2", + "obsidian": "^1.9.12",(File: package.json → devDependencies)
- Jest (^30.1.1) vs ts-jest (^29.4.1): ts-jest v29 warns that Jest 30 is untested and ts-jest’s major follows Jest. ts-jest v30 is not generally available — either pin Jest to ^29.x now or upgrade ts-jest to a v30 release when it exists, then run the test suite to verify. Do not silence ts-jest’s version checker unless you accept the risk.
versions.json (1)
67-69: Added mapping for 1.11.0 → 1.9.12 — LGTM.
Consistent with manifest.minAppVersion and release intent.Please run the provided cross-file check script (see package.json comment) to ensure future bumps stay in lockstep.
manifest.json (1)
4-5: Version 1.11.0 with minAppVersion 1.9.12 — LGTM.
Matches versions.json mapping.Given the new minimum, confirm no API usage requires a higher Obsidian core, and consider updating the devDependency "obsidian" types to ≥1.9 for compile-time coverage (see package.json comment).
This pull request updates the version to 1.11.0 and sets the minimum Obsidian version to 1.9.12.
Summary by CodeRabbit