Instana Agent Implementation #1064
Conversation
Instana Agent Implementation containing necessary framework code and tests.
Incorporated suggestions Co-authored-by: Felix Marx <[email protected]>
saurabhrajguru
force-pushed
the
instana-agent-impl
branch
from
b8c185a
to
809159a
Compare
|
@anthonydahanne @pivotal-david-osullivan and Java Buildpack maintainers. We have implemented the support for Instana APM on Java Buildpack, we were able successfully test the code on CF account. Thank you |
|
@anthonydahanne @pivotal-david-osullivan @dmikusa and Java Buildpack maintainers. We would really appreciate if someone could respond on this. There will be announcement of the integration once this is released. |
| ['latest', download_uri] | ||
| end | ||
|
|
||
| def setup_variables |
There was a problem hiding this comment.
why don't you use the standard way of loading configuration?
Please have a look at: https://github.com/cloudfoundry/java-buildpack/blob/main/config/spring_auto_reconfiguration.yml for example, and provide a similar file for your integration.
thank you
There was a problem hiding this comment.
The reason being we can't publish the build as well as build metadata without proper authentication (In this case Agent Key).
This standard way of loading configuration goes against our policy of serving the build.
There are other APM providers who use the similar policy (For example - Dynatrace).
I hope this clears on why we are unable to use standard configuration for this.
There was a problem hiding this comment.
Looking at the repo we see similar approach and the code on the Dynatrace agent.
https://github.com/cloudfoundry/java-buildpack/blob/main/lib/java_buildpack/framework/dynatrace_one_agent.rb
Instana Agent Implementation containing necessary framework code and tests.
This will enable Instana Agent initialization and configuration for Java buildpack.