Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instana Agent Implementation #1064
base: main
Are you sure you want to change the base?
Instana Agent Implementation #1064
Changes from all commits
4a54bf4
809159a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why don't you use the standard way of loading configuration?
Please have a look at: https://github.com/cloudfoundry/java-buildpack/blob/main/config/spring_auto_reconfiguration.yml for example, and provide a similar file for your integration.
thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason being we can't publish the build as well as build metadata without proper authentication (In this case Agent Key).
This standard way of loading configuration goes against our policy of serving the build.
There are other APM providers who use the similar policy (For example - Dynatrace).
I hope this clears on why we are unable to use standard configuration for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the repo we see similar approach and the code on the Dynatrace agent.
https://github.com/cloudfoundry/java-buildpack/blob/main/lib/java_buildpack/framework/dynatrace_one_agent.rb