Skip to content

fix: add missing security group outputs #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: add missing security group outputs #116

wants to merge 4 commits into from

Conversation

@nitrocode
Copy link
Member

@nitrocode nitrocode commented Nov 22, 2024

what

  • add missing security group outputs

why

  • useful when we need to reference the security group that the vpn uses

references

@mergify mergify bot added the triage Needs triage label Nov 22, 2024
@nitrocode nitrocode added the patch A minor, backward compatible change label Nov 22, 2024
@richardgavel-ordinaryexperts
Copy link

richardgavel-ordinaryexperts commented Dec 12, 2024

Shouldn't the new outputs be based on local.security_group_enabled, not local.enabled?

nitrocode
nitrocode commented Dec 13, 2024
View reviewed changes
nitrocode
nitrocode commented Dec 13, 2024
View reviewed changes
@nitrocode
Copy link
Member Author

nitrocode commented Dec 13, 2024

/terratest

@nitrocode nitrocode marked this pull request as ready for review December 13, 2024 07:21
@nitrocode nitrocode requested review from a team as code owners December 13, 2024 07:21
@adamcrews adamcrews mentioned this pull request Mar 26, 2025
Merged
@mergify
Copy link

mergify bot commented Jun 12, 2025

💥 This pull request now has conflicts. Could you fix it @nitrocode? 🙏

@mergify mergify bot added the conflict This PR has conflicts label Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johncblandii johncblandii Awaiting requested review from johncblandii johncblandii is a code owner automatically assigned from cloudposse/contributors

@RoseSecurity RoseSecurity Awaiting requested review from RoseSecurity RoseSecurity is a code owner automatically assigned from cloudposse/contributors

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

conflict This PR has conflicts patch A minor, backward compatible change triage Needs triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Output for security group created

3 participants

@nitrocode @richardgavel-ordinaryexperts