Update rocm_version.h include so that it works for ROCm 5.6 and above

[smuzaffar]

As suggested by @fwyzard , this change allows cmssw to build with both ROCm 5.6 and 6.X.

[cmsbuild]

cms-bot internal usage

[smuzaffar]

please test with cms-sw/cmsdist#9153

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44824/40068

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

• HeterogeneousCore/ROCmServices (heterogeneous)

@makortel, @fwyzard can you please review it and eventually sign? Thanks.
@makortel, @rovere, @missirol this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44824/40069

• This PR adds an extra 12KB to repository

[cmsbuild]

Pull request #44824 was updated. @fwyzard, @makortel, @cmsbuild can you please check and sign again.

[smuzaffar]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-069796/39054/summary.html
COMMIT: 6f7fa6a
CMSSW: CMSSW_14_1_X_2024-04-24-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44824/39054/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 50 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3319852
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3319823
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[smuzaffar]

@makortel, @fwyzard can you please review this?

[makortel]

+heterogeneous

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[smuzaffar]

@cms-sw/orp-l2 , can you please merge this? Once this is in then I can merge cms-sw/cmsdist#9153 (ROCm revert) and trigger few NON-LTO builds

[antoniovilela]

@cms-sw/orp-l2 , can you please merge this? Once this is in then I can merge cms-sw/cmsdist#9153 (ROCm revert) and trigger few NON-LTO builds

Ok, will merge this PR and not cms-sw/cmsdist#9153.

[antoniovilela]

+1