Debug rhel 8 packagekit #22654
Draft
Debug rhel 8 packagekit #22654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelly
added
the
no-test
jelly
force-pushed
the
debug-rhel-8-packagekit
branch
3 times, most recently
from
fbf4d91 to
19b2987
Compare
Introduce a `with_session` helper which creates the session, optionally a subscription and cleans them up.
Implement `is_installed` for the appstream apps page and switch to the packagemanager implementation. This also drops the progress callback as it wasn't use in the PackageKit scenario and dnf5daemon doesn't give us any useful progress information at all.
The confusingly named packagekit.js file will be empty after moving everything to the packagemanager class and to where it is used.
Implement `install_packages` for the appstream apps page and switch to the PacakgeManager implementation. This also drops the ProgressReporter wrapper which isn't required as we have one progress event to watch.
With these two new methods we can replace the remove functionality in the apps page with the packagemanager implementation.
Implement the last two functions needed to move the `refresh` method of the apps page over to the packagemanager implementation.
This removes the confusingly named packagekit.js file and moves the refresh function to where it is used.
These are no longer used via "packagekit" but only via the PackageManager class.
Closing the single dbus client shared across all packagemanager instances breaks multiple operations in parallel. Subscriptions will now not be properly cleaned up as `remove-match` isn't implemented in the Python bridge.
Everyone has moved to the PackageManager method.
Close the DBus client after checking if packagekit/dnf5daemon dbus's services exist.
jelly
force-pushed
the
debug-rhel-8-packagekit
branch
from
ec212f8 to
70fea30
Compare
The kpatch code already uses the install_dialog which uses the PackageManager class internally so there is no issue in moving this to check_missing_packages. As kpatch only works on RHEL, this would use PackageKit anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.