Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: enable SimplifyBoolIdenticalTrueRector #9244

Conversation

samsonasik
Copy link
Member

Description

To clean up unnecessary compare true/false on boolean type data, and clean up phpstan-baseline.php

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@samsonasik samsonasik force-pushed the refactor-enable-simplify-bool-identical-true branch from de3d33e to 3f8feaa Compare October 30, 2024 09:44
@samsonasik
Copy link
Member Author

Ready to merge 👍

@samsonasik
Copy link
Member Author

Thank you @paulbalandan for the review, let's merge ;)

@samsonasik samsonasik merged commit caf4d53 into codeigniter4:develop Oct 30, 2024
41 checks passed
@samsonasik samsonasik deleted the refactor-enable-simplify-bool-identical-true branch October 30, 2024 10:05
@kenjis kenjis added the refactor Pull requests that refactor code label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Pull requests that refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants