Skip to content

Driving a course in Metadrive test #30964

Closed
bongbui321 wants to merge 5 commits intocommaai:masterfrom
bongbui321:mtd
Closed

Driving a course in Metadrive test #30964
bongbui321 wants to merge 5 commits intocommaai:masterfrom
bongbui321:mtd

Conversation

@bongbui321
Copy link
Contributor

@bongbui321 bongbui321 commented Jan 11, 2024

For #30694 (WIP). This is a draft for the bounty. Currently has 3 failure cases: 2 collisions and drive out of lane. I have a few questions regarding the bounty:

  1. Do you want a new driving course from the old one I'm not sure what you mean by driving a defined course?
  2. For logging as artifacts, this would make this bounty the same as #30693 right? since you would have to be able to run on CI anyway, so do you want that part to be on the other bounty or this one still?

@github-actions github-actions bot added CI / testing simulation running openpilot in environments like CARLA tools labels Jan 11, 2024
@jnewb1
Copy link
Contributor

jnewb1 commented Jan 11, 2024

For logging as artifacts, this would make this bounty the same as #30693 right?

This just means we have to get loggerd and encoderd running on PC and it creating logs, adding it as an artifact would be easy to add once we have it creating the logs

@jnewb1
Copy link
Contributor

jnewb1 commented Jan 11, 2024

Do you want a new driving course from the old one I'm not sure what you mean by driving a defined course?

The circle course is fine, just have it complete that.

@bongbui321 bongbui321 marked this pull request as draft January 11, 2024 16:30
@adeebshihadeh
Copy link
Contributor

  1. For logging as artifacts, this would make this bounty the same as #30693 right? since you would have to be able to run on CI anyway, so do you want that part to be on the other bounty or this one still?

Good point, I moved that to the other bounty.

q.put("reset")
start_time = time.monotonic()
user_disengage_once = False
disengage_events = ('stockAeb', 'fcw', 'ldw')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't tell you what you need to know. the point of the bounty is to determine whether openpilot stayed in its lane, drove a reasonable, etc. and finished the course

@adeebshihadeh
Copy link
Contributor

@bongbui321 I'm unlocking the bounty since it's been a couple weeks. feel free to open the PR back up if you start working on it again

@bongbui321 bongbui321 deleted the mtd branch March 31, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI / testing simulation running openpilot in environments like CARLA tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants