FCA Giorgio: Alfa Romeo Stelvio / Giulia#33618
Closed
jyoung8607 wants to merge 8 commits intocommaai:masterfrom
Closed
FCA Giorgio: Alfa Romeo Stelvio / Giulia#33618jyoung8607 wants to merge 8 commits intocommaai:masterfrom
jyoung8607 wants to merge 8 commits intocommaai:masterfrom
Conversation
Collaborator
Author
|
We need this route uploaded to the CI bucket: |
Contributor
|
This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity. |
jyoung8607
force-pushed
the
fca-giorgio
branch
from
98fc49f to
4b73eeb
Compare
|
hello is this already works on giulia ? |
Comment on lines
+161
to
+164
| # TODO: Shouldn't be necessary. Refactor CarSpecificEvents with a simple default case, override only if necessary. | ||
| # Default case should cover FCA Giorgio, Subaru, Mazda, maybe Ford. Further simplification possible. | ||
| elif self.CP.carName == 'fca_giorgio': | ||
| events = self.create_common_events(CS.out, CS_prev) |
Contributor
There was a problem hiding this comment.
@sshane is this done? I think we can close this PR
Collaborator
Author
There was a problem hiding this comment.
Yeah that's done, and I'll take care of the rest whenever FCA Giorgio comes in.
|
hi, is this ready to be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Car
Support for Alfa Romeo Stelvio and Giulia.
Very few actual openpilot changes needed, mainly opening this as a CI runner during development.