Skip to content

Car Port: Kia Carnival HEV 2025 (HDA2)#34246

Closed
ccdunder wants to merge 1 commit intocommaai:masterfrom
ccdunder:kia-carnival-25
Closed

Car Port: Kia Carnival HEV 2025 (HDA2)#34246
ccdunder wants to merge 1 commit intocommaai:masterfrom
ccdunder:kia-carnival-25

Conversation

@ccdunder
Copy link

@ccdunder ccdunder commented Dec 14, 2024

Checklist

  • added entry to CAR in selfdrive/car/*/values.py and ran selfdrive/car/docs.py to generate new docs
  • test route added to routes.py
  • route with openpilot: 6c0069dcd5bbb6c1/00000020--6b95507969
  • route with stock system: 6c0069dcd5bbb6c1/00000021--e6c25dde2d
  • car harness used (if comma doesn't sell it, put N/A): Hyundai Q

Dependencies:

Relation to #34163:
I don't believe this is a dupe. Happy to chat further if there are questions or concerns.

At the time this was opened,

  1. This code is novel, doesn't duplicate or overlap.
  2. This car is novel (HEV, first year).
  3. This code was developed independently.
    • I id'd the harness using schematics, and pulled fingerprints from my own car. Then I fixed issues.
  4. #_34163 hadn't moved in over a week.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@ccdunder ccdunder marked this pull request as draft December 15, 2024 00:17
@ccdunder ccdunder marked this pull request as ready for review December 15, 2024 00:20
@sunnyhaibin
Copy link
Contributor

This PR is a duplicate of #34163.

@ccdunder
Copy link
Author

ccdunder commented Dec 15, 2024

This PR is a duplicate of #34163.

I've updated the description to address this.

@ccdunder ccdunder changed the title Car Port: Kia Carnival 2025 HDA2 (Hybrid & ICE) Car Port: Kia Carnival HEV 2025 (HDA2) Dec 16, 2024
@ccdunder ccdunder force-pushed the kia-carnival-25 branch 5 times, most recently from c14f34e to 5924efb Compare December 16, 2024 23:38
@github-actions
Copy link
Contributor

This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity.

@github-actions github-actions bot added the stale label Dec 27, 2024
@ccdunder
Copy link
Author

This is still open and ready for review.

@github-actions github-actions bot removed the stale label Dec 29, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity.

@github-actions github-actions bot added the stale label Jan 8, 2025
@ccdunder
Copy link
Author

ccdunder commented Jan 8, 2025

Still open

@github-actions github-actions bot removed the stale label Jan 9, 2025
@github-actions
Copy link
Contributor

This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity.

@github-actions github-actions bot added the stale label Jan 19, 2025
@github-actions
Copy link
Contributor

This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes.

@github-actions github-actions bot closed this Jan 22, 2025
@ccdunder
Copy link
Author

This is alive and well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants