Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cabana: miscellaneous bug fixes and enhancements #34297

Merged
merged 9 commits into from
Dec 21, 2024

Conversation

deanlee
Copy link
Contributor

@deanlee deanlee commented Dec 20, 2024

  1. Dim inactive messages in BinaryView with gray color:
    Screenshot from 2024-12-21 02-54-43
  2. Add series type selector to chart toolbar for quick chart type changes:
    2024-12-21_02-58
  3. Fix incorrect slider groove rect on high DPI:
Before After
Screenshot from 2024-12-21 02-45-02 Screenshot from 2024-12-21 02-46-02
  1. Fixed toolbar appearance on macOS:
Before After
Screenshot from 2024-12-21 02-48-48 Screenshot from 2024-12-21 02-49-01
  1. Fix LogSlider to prevent value changes after setting the same range.
  2. Ensure message size doesn't exceed CAN_MAX_DATA_BYTES (64) in the message edit dialog.
  3. Improve VideoWidget layout for better visual alignment.
  4. Update hex value formatting to display in uppercase (e.g., 0x3C2, 0x4DF, instead of lowercase 3c2, 4df).
  5. Fix various UI components, like sizeHint, to properly scale on high DPI screens.
  6. Improve "What's This" text for chart view interactions:
    Screenshot from 2024-12-21 12-21-12

@github-actions github-actions bot added the tools label Dec 20, 2024
@deanlee deanlee force-pushed the cabana_misc_improvement branch from 361d920 to e1bbb61 Compare December 21, 2024 16:22
@deanlee deanlee force-pushed the cabana_misc_improvement branch from e1bbb61 to 5bd8289 Compare December 21, 2024 17:20
@adeebshihadeh adeebshihadeh merged commit 9e8815d into commaai:master Dec 21, 2024
16 checks passed
@deanlee deanlee deleted the cabana_misc_improvement branch December 21, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants