Skip to content

Speed up CI setup to ~25-~40s with actions/cache use #34321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pantew869 wants to merge 3 commits into from
Closed

Speed up CI setup to ~25-~40s with actions/cache use #34321

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9844ca2
add cache
pantew869 Dec 30, 2024
f66aa76
rerun CI
pantew869 Dec 30, 2024
46a0c94
rerun CI
pantew869 Dec 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 31 additions & 1 deletion .github/workflows/setup/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,36 @@ runs:
run: |
find . -type f -executable -not -perm 755 -exec chmod 755 {} \;
find . -type f -not -executable -not -perm 644 -exec chmod 644 {} \;
- id: docker-cache-restore
uses: ./.github/workflows/auto-cache
with:
path: .ci_cache/docker
restore-keys: docker-${{ hashFiles('Dockerfile.openpilot_base', 'tools/install_ubuntu_dependencies.sh', 'tools/install_python_dependencies.sh', 'uv.lock', '.github/workflows/setup/action.yaml') }}
key: docker-${{ hashFiles('Dockerfile.openpilot_base', 'tools/install_ubuntu_dependencies.sh', 'tools/install_python_dependencies.sh', 'uv.lock', '.github/workflows/setup/action.yaml') }}
Comment on lines +54 to +59
Copy link
Contributor

@maxime-desroches maxime-desroches Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to do all that extra caching when using a namespace runner, aka when this condition is true: ((github.repository == 'commaai/openpilot') && ((github.event_name != 'pull_request') || (github.event.pull_request.head.repo.full_name == 'commaai/openpilot')))


- shell: bash
if: steps.docker-cache-restore.outputs.cache-hit == 'true'
run: |
sudo setfacl --restore=.ci_cache/docker/permissions
sudo rm -rf /var/lib/docker
sudo mv .ci_cache/docker /var/lib/
sudo systemctl restart docker
# build our docker image
- shell: bash
run: eval ${{ env.BUILD }}
if: steps.docker-cache-restore.outputs.cache-hit != 'true'
run: |
eval ${{ env.BUILD }}
docker builder prune -a --force
sudo systemctl stop docker
sudo rm -rf /var/lib/docker/volumes
sudo cp -R /var/lib/docker .ci_cache/
sudo getfacl -R .ci_cache/docker > .ci_cache/docker/permissions
sudo chmod -R 777 .ci_cache/docker
- id: docker-cache-save
if: steps.docker-cache-restore.outputs.cache-hit != 'true'
uses: actions/cache/save@v4
env:
ZSTD_NBTHREADS: 0
Copy link
Contributor

@maxime-desroches maxime-desroches Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's interesting. How much does it affect the total setup time?

with:
path: .ci_cache/docker
key: docker-${{ hashFiles('Dockerfile.openpilot_base', 'tools/install_ubuntu_dependencies.sh', 'tools/install_python_dependencies.sh', 'uv.lock', '.github/workflows/setup/action.yaml') }}
Loading