Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Add missing uppercase_keyboard UI view #34347

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

CI: Add missing uppercase_keyboard UI view #34347

wants to merge 20 commits into from
+7 −2

Conversation

ugtthis
Copy link
Contributor

@ugtthis ugtthis commented Jan 9, 2025 •
edited
Loading

- The tap coordinates may be a little off possibly, will change
- Still in the process of trying to run the UI Preview workflow infra on my fork to show it works

jyoung-comment

How I verified

  • I used another branch to draw a circle where the coordinates are hitting. Branch used here
  • Used the Artifact download URL to verify that the png has a circle hitting the shift and shows uppercase as shown below

keyboard_uppercase.png w/circle

keyboard_uppercase

@ugtthis ugtthis mentioned this pull request Jan 9, 2025
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025 •
edited
Loading

UI Preview

All Screenshots

@ugtthis ugtthis marked this pull request as ready for review January 10, 2025 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ugtthis