Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed openpilot.common.numpy_fast #34331 #34357

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Shaikimram
Copy link

Description
This pull request removes the numpy_fast.py utility and its references across the OpenPilot codebase and opendbc repository. The numpy_fast optimization is no longer necessary in the post-comma two world, as modern numpy functions (np.clip, np.interp, np.mean) offer comparable performance and maintainability.

Changes made:
Removed the numpy_fast.py file from the common directory.
Replaced calls to clip, interp, and mean in dependent files with equivalent numpy functions (np.clip, np.interp, np.mean).
Updated the opendbc repository to ensure no lingering dependencies on numpy_fast.
Verification
Verified all impacted files by replacing references to numpy_fast functions with numpy's built-in alternatives and ensured compatibility.
Additional Notes
Pending Tasks: Unit tests and manual testing in critical modules were not performed as part of this change. Further validation is recommended to ensure no regressions or unexpected behavior.
Removed all remaining references to numpy_fast from the opendbc submodule.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@Shaikimram Shaikimram closed this Jan 11, 2025
@Shaikimram Shaikimram reopened this Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant