Keyboard UX/UI: Access to caps lock - clearer icons#34362
Merged
adeebshihadeh merged 20 commits intocommaai:masterfrom Jan 23, 2025
Merged
Keyboard UX/UI: Access to caps lock - clearer icons#34362adeebshihadeh merged 20 commits intocommaai:masterfrom
adeebshihadeh merged 20 commits intocommaai:masterfrom
Conversation
ugtthis
changed the title
Contributor
UI Previewkeyboard : |
master  | proposed  |
diff  | composite diff  |
keyboard_uppercase : $${\color{red}\text{DIFFERENT}}$$
master  | proposed  |
diff  | composite diff  |
All Screenshots
 |  |
 |  |
 |  |
 |  |
 |  |
 |  |
 |  |
 |  |
 |  |
 | |
| |
sshane
reviewed
Jan 13, 2025
Contributor
Author
|
Now it's a simpler implementation. I do like the double tap feature cause I think it is the better UX solution but it's not yet that important especially since there is a simpler solution that solves the main problem, which is to have access to caps lock New UX - no double tap
|
ugtthis
changed the title
ssysm
pushed a commit
to MOTIF-lab/openpilot
that referenced
this pull request
Feb 13, 2025
* add-slash-to uppercase * caps-lock-works * leaner and simpler * this is simpler * better... * simpler * rm comments * clearer naming * make more explicit * change to SHIFT_KEY * change name * works - no more double tap * better and works * more readable * simpler but still readable * more self documenting * whoops * add back - needed for if string requirment not meant
qzwf
pushed a commit
to qzwf/openpilot
that referenced
this pull request
Feb 25, 2025
* add-slash-to uppercase * caps-lock-works * leaner and simpler * this is simpler * better... * simpler * rm comments * clearer naming * make more explicit * change to SHIFT_KEY * change name * works - no more double tap * better and works * more readable * simpler but still readable * more self documenting * whoops * add back - needed for if string requirment not meant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was reminded again to do this once I saw the comment from discord
Comparison
Proposed UI/UX Enlarged