Skip to content

ui: replace Qt spinner and text with python spinner and text #35003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 32 commits into from
Closed
Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
e674215
remove qt spinner, text
deanlee Mar 16, 2025
900564f
remove wrappers
deanlee Mar 20, 2025
1095ff4
no ui in ci
deanlee Mar 20, 2025
805ee4d
move spinner to thread
deanlee Mar 20, 2025
a29810e
revert changes to consumers
incognitojam Apr 16, 2025
cf70261
move Spinner wrapper into system/ui
incognitojam Apr 16, 2025
b9d7c60
rewrite
incognitojam Apr 16, 2025
87572e2
Merge remote-tracking branch 'origin/master' into ui_remove_qt_spinne…
incognitojam Apr 16, 2025
6f268e8
avoid typing renderer
incognitojam Apr 16, 2025
ff1fc61
Revert "avoid typing renderer"
incognitojam Apr 16, 2025
e5850df
typing...
incognitojam Apr 16, 2025
c2a2f35
this also works
incognitojam Apr 16, 2025
442f791
update imports
incognitojam Apr 16, 2025
c958755
wait for renderer first
incognitojam Apr 16, 2025
1eb834a
fix import and init var
incognitojam Apr 16, 2025
ef157f6
renderer can be None, sometimes we don't want to init - e.g. CI
incognitojam Apr 16, 2025
458705d
no ui in ci
incognitojam Apr 16, 2025
95b9d4e
update import
incognitojam Apr 16, 2025
e561567
rm unused
incognitojam Apr 16, 2025
c12244f
rename
incognitojam Apr 16, 2025
5d0e13f
rename2
incognitojam Apr 16, 2025
b3cb586
update progress bar: rounded and correct colour
incognitojam Apr 17, 2025
c664165
match spinner text font size
incognitojam Apr 17, 2025
280fa14
text: match font size
incognitojam Apr 17, 2025
432e9e5
text: method stubs
incognitojam Apr 17, 2025
03df050
text: line breaks and indentation
incognitojam Apr 17, 2025
69381a0
text: line height
incognitojam Apr 17, 2025
d399a50
fixes
incognitojam Apr 17, 2025
c639729
spinner vertical alignment
incognitojam Apr 17, 2025
bf2c8b8
Merge remote-tracking branch 'origin/master' into ui_remove_qt_spinne…
incognitojam Apr 22, 2025
2aca052
fix merge
incognitojam Apr 22, 2025
9452fa3
Merge remote-tracking branch 'origin/master' into ui_remove_qt_spinne…
incognitojam Apr 22, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 0 additions & 52 deletions common/spinner.py

This file was deleted.

63 changes: 0 additions & 63 deletions common/text_window.py

This file was deleted.

4 changes: 0 additions & 4 deletions selfdrive/ui/SConscript
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,6 @@ if GetOption('extras'):

qt_env.SharedLibrary("qt/python_helpers", ["qt/qt_window.cc"], LIBS=qt_libs)

# spinner and text window
qt_env.Program("_text", ["qt/text.cc"], LIBS=qt_libs)
qt_env.Program("_spinner", ["qt/spinner.cc"], LIBS=qt_libs)

# setup and factory resetter
qt_env.Program("qt/setup/reset", ["qt/setup/reset.cc"], LIBS=qt_libs)
qt_env.Program("qt/setup/setup", ["qt/setup/setup.cc", asset_obj],
Expand Down
120 changes: 0 additions & 120 deletions selfdrive/ui/qt/spinner.cc

This file was deleted.

37 changes: 0 additions & 37 deletions selfdrive/ui/qt/spinner.h

This file was deleted.

3 changes: 0 additions & 3 deletions selfdrive/ui/qt/spinner_larch64

This file was deleted.

64 changes: 0 additions & 64 deletions selfdrive/ui/qt/text.cc

This file was deleted.

3 changes: 0 additions & 3 deletions selfdrive/ui/qt/text_larch64

This file was deleted.

7 changes: 0 additions & 7 deletions selfdrive/ui/spinner

This file was deleted.

7 changes: 0 additions & 7 deletions selfdrive/ui/text

This file was deleted.

Loading