feat(esim): athena bindings + LPA input validations #35325
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adeebshihadeh
requested changes
May 22, 2025
greatgitsby
force-pushed
the
feat/esim-athena
branch
2 times, most recently
from
d3ba968 to
5cf19c4
Compare
greatgitsby
force-pushed
the
feat/esim-athena
branch
from
5cf19c4 to
b36c107
Compare
greatgitsby
force-pushed
the
feat/esim-athena
branch
from
77a44ef to
1ef5bad
Compare
|
This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity. |
|
This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes. |
adeebshihadeh
requested changes
Jun 25, 2025
greatgitsby
force-pushed
the
feat/esim-athena
branch
from
fdd62a1 to
55ccc87
Compare
|
iccid validation format derived from: https://www.itu.int/en/ITU-T/inr/forms/Pages/iin.aspx |
greatgitsby
changed the title
|
This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity. |
|
This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #34924
not adding
delete_profilehere for now. too risky for user to accidentally delete profile and not be able to recover it.happy case (get profiles)
happy case (download profile)
esim-athena.webm
sad case (enable invalid profile)