Skip to content

replay: convert UBWC VisionBuf to nv12 with sde rotator #35575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jakethesnake420
Copy link
Contributor

@jakethesnake420 jakethesnake420 commented Jun 18, 2025

https://github.dev/commaai/agnos-kernel-sdm845/blob/0ba5f48f36d4e43c3b095a410279ed08050209fb/drivers/gpu/drm/msm/sde/sde_hw_rot.c#L583

decompress NV12 UBWC VisionBuf to NV12 with sde rotator hardware. This uses v4l2 to set the input frame buffer format (in this case, V4L2_PIX_FMT_NV12_UBWC) to the desired format (decompressed V4L2_PIX_FMT_NV12). A program will provide put_frame(vision_buf), with a pointer to an allocated visionbuf which needs to be decompressed which will then send the command to the hardware. Then call get_frame which will poll the rotator fd and return a pointer to the decompressed vision buffer.

Note that OUTPUT buffers are the inputs (nv12_ubwc) and CAPTURE buffers are the output (nv12).

@jakethesnake420 jakethesnake420 marked this pull request as draft June 18, 2025 04:40
@github-actions github-actions bot added the tools label Jun 18, 2025
@jakethesnake420 jakethesnake420 force-pushed the sde_rotator branch 2 times, most recently from 9cfb40e to 2e07b4b Compare June 18, 2025 04:56
@jakethesnake420 jakethesnake420 force-pushed the sde_rotator branch 2 times, most recently from 5998b7e to f926e86 Compare June 18, 2025 05:00
Copy link
Contributor

This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity.

@github-actions github-actions bot added the stale label Jun 28, 2025
Copy link
Contributor

This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes.

@github-actions github-actions bot closed this Jun 30, 2025
@adeebshihadeh adeebshihadeh reopened this Jun 30, 2025
@github-actions github-actions bot removed the stale label Jul 2, 2025
Copy link
Contributor

This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity.

@github-actions github-actions bot added stale and removed stale labels Jul 11, 2025
Copy link
Contributor

This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity.

@github-actions github-actions bot added the stale label Jul 21, 2025
Copy link
Contributor

This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes.

@github-actions github-actions bot closed this Jul 26, 2025
@adeebshihadeh adeebshihadeh reopened this Jul 26, 2025
@github-actions github-actions bot removed the stale label Jul 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants