replay: convert UBWC VisionBuf to nv12 with sde rotator#35575
Closed
jakethesnake420 wants to merge 1 commit intocommaai:masterfrom
Closed
replay: convert UBWC VisionBuf to nv12 with sde rotator#35575jakethesnake420 wants to merge 1 commit intocommaai:masterfrom
jakethesnake420 wants to merge 1 commit intocommaai:masterfrom
Conversation
jakethesnake420
force-pushed
the
sde_rotator
branch
2 times, most recently
from
9cfb40e to
2e07b4b
Compare
jakethesnake420
force-pushed
the
sde_rotator
branch
2 times, most recently
from
5998b7e to
f926e86
Compare
jakethesnake420
force-pushed
the
sde_rotator
branch
from
f926e86 to
5dcc5cc
Compare
Contributor
|
This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity. |
Contributor
|
This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes. |
Contributor
|
This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity. |
Contributor
|
This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity. |
Contributor
|
This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes. |
Contributor
|
Does this work? If so, we can just merge after a little cleanup. |
Contributor
Author
The final submission is here #35821 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.dev/commaai/agnos-kernel-sdm845/blob/0ba5f48f36d4e43c3b095a410279ed08050209fb/drivers/gpu/drm/msm/sde/sde_hw_rot.c#L583
decompress NV12 UBWC VisionBuf to NV12 with sde rotator hardware. This uses v4l2 to set the input frame buffer format (in this case, V4L2_PIX_FMT_NV12_UBWC) to the desired format (decompressed V4L2_PIX_FMT_NV12). A program will provide put_frame(vision_buf), with a pointer to an allocated visionbuf which needs to be decompressed which will then send the command to the hardware. Then call get_frame which will poll the rotator fd and return a pointer to the decompressed vision buffer.
Note that OUTPUT buffers are the inputs (nv12_ubwc) and CAPTURE buffers are the output (nv12).