less dirty comma zero #35667
Draft
less dirty comma zero #35667
+158
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Squashed commit of the following: commit b982f83 Merge: 31f7e8f 0f1a9d5 Author: Andrei Radulescu <[email protected]> Date: Sun Jun 29 10:23:19 2025 +0300 Merge branch 'master' into modeld-autodetect commit 31f7e8f Author: Andrei Radulescu <[email protected]> Date: Thu Jun 26 00:42:43 2025 +0300 simplify commit 341bbd1 Author: Andrei Radulescu <[email protected]> Date: Thu Jun 26 00:20:37 2025 +0300 fix static analysis commit 5accb2b Author: Andrei Radulescu <[email protected]> Date: Thu Jun 26 00:00:00 2025 +0300 backend from jit commit f71b0fe Author: Andrei Radulescu <[email protected]> Date: Wed Jun 25 21:20:34 2025 +0300 comment why llvm@19 Co-authored-by: Adeeb Shihadeh <[email protected]> commit 506e498 Author: Andrei Radulescu <[email protected]> Date: Wed Jun 25 21:19:33 2025 +0300 Revert "modeld: autodetect tinygrad CUDA backend" This reverts commit 0e9755f. commit 0e9755f Author: Andrei Radulescu <[email protected]> Date: Sun Jun 1 14:11:07 2025 +0300 modeld: autodetect tinygrad CUDA backend commit 3c76ebf Author: Andrei Radulescu <[email protected]> Date: Sat May 31 11:38:36 2025 +0300 modeld: autodetect tinygrad backend
Squashed commit of the following: commit af32100 Merge: a0adab3 0f1a9d5 Author: Andrei Radulescu <[email protected]> Date: Sun Jun 29 10:34:20 2025 +0300 Merge branch 'master' into camera-transformations-pc commit a0adab3 Author: Andrei Radulescu <[email protected]> Date: Sun Jun 29 10:34:17 2025 +0300 1280x720 commit d9eb888 Author: Andrei Radulescu <[email protected]> Date: Sun Jun 15 15:56:43 2025 +0300 ui: dynamic fcam_intrinsic_matrix based on sensor type commit b54818b Author: Andrei Radulescu <[email protected]> Date: Wed Jun 4 23:26:49 2025 +0300 sim: pc config width and height commit bb58eba Author: Andrei Radulescu <[email protected]> Date: Wed Jun 4 23:19:25 2025 +0300 transformations: pc config for comma zero
| @@ -145,6 +146,32 @@ def handle_log(self, t: float, which: str, msg: capnp._DynamicStructReader) -> H | |||
| elif which == "carState": | |||
| self.car_speed = abs(msg.vEgo) | |||
|
|
|||
| if PC: | |||
There was a problem hiding this comment.
@fredyshox can you get something like this merged soon? it's for openpilot on PC without an IMU (doesn't need large scale validation)
There was a problem hiding this comment.
also tried a cleaner implementation here #35563 but I doubt I can get something like this merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An overview of what still needs to be merged (less dirty than #35143):
@lukasloetkolben did a route on this branch: https://drive.google.com/drive/folders/1cDq4nWNOdGpmk_uv2ZeiF7hs2rnCqSM1