Skip to content

cabana: Fix slider visual inconsistency by adjusting groove height#35688

Merged
adeebshihadeh merged 1 commit intocommaai:masterfrom
deanlee:cabana_fix_slider
Jul 12, 2025
Merged

cabana: Fix slider visual inconsistency by adjusting groove height#35688
adeebshihadeh merged 1 commit intocommaai:masterfrom
deanlee:cabana_fix_slider

Conversation

@deanlee
Copy link
Contributor

@deanlee deanlee commented Jul 11, 2025

On some platforms, the custom slider handle appears much smaller than the groove, causing a visual imbalance:
Screenshot from 2025-07-11 12-59-05

This PR adjusts the groove height to better match the handle size, improving visual consistency while keeping a native look across platforms.

@github-actions github-actions bot added the tools label Jul 11, 2025
@deanlee deanlee force-pushed the cabana_fix_slider branch from 743b563 to 25d2fb8 Compare July 11, 2025 05:09
@adeebshihadeh adeebshihadeh merged commit 9d7b18c into commaai:master Jul 12, 2025
15 checks passed
@deanlee deanlee deleted the cabana_fix_slider branch July 12, 2025 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants