refactor(raylib): Fix and standardize rounded corners #35729
+49
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheSecurityDev
commented
Jul 14, 2025
| @@ -43,7 +45,7 @@ class PanelType(IntEnum): | |||
| @dataclass | |||
| class PanelInfo: | |||
| name: str | |||
| instance: object | |||
| instance: Widget | |||
There was a problem hiding this comment.
I just did this to fix a type issue in my IDE
There was a problem hiding this comment.
It was the Pylance VSCode extension, if you're wondering. It shows quite a few type issues on a lot of the files, but I can't fix them all.
TheSecurityDev
commented
Jul 14, 2025
| from openpilot.system.ui.lib.text_measure import measure_text_cached | ||
| from openpilot.system.ui.widgets import Widget | ||
|
|
||
| SIDEBAR_WIDTH = 300 | ||
| METRIC_HEIGHT = 126 | ||
| METRIC_WIDTH = 240 | ||
| METRIC_MARGIN = 30 | ||
| METRIC_BORDER_RADIUS = 20 |
There was a problem hiding this comment.
Increases the metrics border radius to match the current UI
TheSecurityDev
commented
Jul 14, 2025
| @@ -143,7 +144,7 @@ def _render_instructions(self, rect: rl.Rectangle) -> None: | |||
|
|
|||
| def _render_qr_code(self, rect: rl.Rectangle) -> None: | |||
| if not self.qr_texture: | |||
| rl.draw_rectangle_rounded(rect, 0.1, 20, rl.Color(240, 240, 240, 255)) | |||
| rl.draw_rectangle_rounded(rect, get_roundness(rect, 30), 20, rl.Color(240, 240, 240, 255)) | |||
There was a problem hiding this comment.
The rounded corners are actually only visible when there's no QR code, which doesn't seem very useful
TheSecurityDev
commented
Jul 14, 2025
| from openpilot.system.ui.lib.scroll_panel import GuiScrollPanel | ||
| from openpilot.system.ui.widgets import Widget | ||
| from openpilot.system.ui.widgets.button import gui_button, ButtonStyle, TextAlignment | ||
| from openpilot.system.ui.widgets.label import gui_label | ||
|
|
||
| # Constants | ||
| MARGIN = 50 | ||
| PANEL_COLOR = rl.Color(30, 30, 30, 255) | ||
| PANEL_BORDER_RADIUS = 10 |
There was a problem hiding this comment.
We really should just make a Panel widget to avoid this stuff being done in different components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a
get_roundnessfunction that takes a rect and aborder_radius(pixels) amount and returns the roundness value for raylib.This allows us to use the same border radius for different-sized panels without having to guess the roundness value. This mainly fixes the inconsistent panel roundness on the home page. I also increased the metrics rounding to match the old UI.
TODO: The experimental mode button also needs rounded, but I will do that in a separate PR once this is merged.
Home panels and metrics (before):
Home panels and metrics (after):
Set speed (before):
Set speed (after):
The ones below don't have much or any difference:
Settings panel (before):
Settings panel (after):
Network panel (before):
Network panel (after):
Alert (before):
Alert (after):