tools: Handle smaller terminal sizes in replay#36766
Merged
adeebshihadeh merged 3 commits intocommaai:masterfrom Dec 9, 2025
Merged
tools: Handle smaller terminal sizes in replay#36766adeebshihadeh merged 3 commits intocommaai:masterfrom
adeebshihadeh merged 3 commits intocommaai:masterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:
- Convert your PR to a draft unless it's ready to review
- Read the contributing docs
- Before marking as "ready for review", ensure:
- the goal is clearly stated in the description
- all the tests are passing
- the change is something we merge
- include a route or your device' dongle ID if relevant
deanlee
pushed a commit
to deanlee/openpilot
that referenced
this pull request
Dec 29, 2025
* Only show help if there's room for it * show less * wording
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When running
op replay --demoin VS Code (or any terminal with a custom size), the terminal height can be too small to display all the available commands. This was not being detected, leading to a bad experience for terminals smaller than 23 rows. The help is now only conditionally added, along with a suggestion to enlarge the terminal, if there is room.Verification
op replay --demo on screen height < 23 before:
op replay --demo on screen height < 17 before:
op replay --demo on screen height < 23 after:
op replay --demo on screen height < 17 after:
