tools: Handle smaller terminal sizes in replay #36766
Open
+7
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When running
op replay --demoin VS Code (or any terminal with a custom size), the terminal height can be too small to display all the available commands. This was not being detected, leading to a bad experience for terminals smaller than 23 rows. The help is now only conditionally added, along with a suggestion to enlarge the terminal, if there is room.Verification
op replay --demo on screen height < 23 before:

op replay --demo on screen height < 17 before:

op replay --demo on screen height < 23 after:

op replay --demo on screen height < 17 after:
