onboarding: automatically go back after selecting network #37017
+7
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mici raylib UI Preview✅ Videos are identical! View Diff Report |
TheSecurityDev
commented
Jan 23, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the onboarding flow by automatically navigating back to the network setup page after successfully connecting to a WiFi network, addressing user feedback about the confusing WiFi connection flow during device setup.
Changes:
- Added a
back_on_activateparameter toWifiUIMicito enable automatic navigation after network connection - Modified the onboarding flow to use this new feature while keeping the settings flow unchanged
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
system/ui/mici_setup.py |
Enables automatic back navigation during onboarding by passing back_on_activate=True to WifiUIMici |
selfdrive/ui/mici/layouts/settings/network/wifi_ui.py |
Implements the back_on_activate feature by closing modal overlays and triggering the back callback when a network connection is activated |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
raylib UI PreviewAll Screenshots
|
Contributor
|
I thought I already added this, did it get reverted? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After connecting to a WiFi network during onboarding, this PR makes it automatically go back to the network setup page so the user can continue to downloading, instead of remaining in the WiFi page.
This was based on user feedback in Discord about how the current flow was confusing. Also partly addresses #36916
When the user connects...
... it will now go back to here:
