clips: allow mici UI (now default) #37070
Open
+1
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR switches the tools/clip/run.py script to use the mici UI by default for generated clips, while still allowing the previous "big" UI via a flag.
Changes:
- Change the
--bigCLI flag so that it no longer defaults toTrue, making the mici UI the default rendering mode. - Remove the assertion that previously prevented running clips with the mici UI, allowing both UIs to be used depending on the flag.
- Keep environment setup and rendering logic wired through the
bigflag so the correct UI andBIGenv variable are still applied when requested.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the assertion and make
--bigfalse by default for clips. The metadata overlay will need the size adjusted, but that can be done separately../tools/clip/run.py --demo -t "mici UI"output-mici.mp4
./tools/clip/run.py --demo --big -t "big UI"output-big.mp4
./tools/clip/run.py --demo --qcam -t "mici UI (qcam)"output-mici-qcam.mp4
./tools/clip/run.py --demo --big --qcam -t "big UI (qcam)"output-big-qcam.mp4