rmlui: add optional SVG plugin support #29200
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
alexandre-charlot_qonto seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
jcar87
reviewed
Dec 22, 2025
Comment on lines
+7
to
+12
| - find_package(lunasvg REQUIRED) | ||
| - | ||
| - list(APPEND CORE_LINK_LIBS ${LUNASVG_LIBRARIES}) | ||
| - list(APPEND CORE_INCLUDE_DIRS ${LUNASVG_INCLUDE_DIR}) | ||
| + find_package(lunasvg REQUIRED CONFIG) | ||
| + list(APPEND CORE_LINK_LIBS lunasvg::lunasvg) |
Contributor
There was a problem hiding this comment.
is this patch necessary? Are there errors if this patch is not included?
Conan already configures the build to prefer CONFIG, and LUNASVG_LIBRARIES should be defined to contain lunasvg::lunasvg - however if it isn't, we prefer to do it via the recipe rather than patches:
deps.set_property("lunasvg", "cmake_additional_variables_prefixes", ["LUNASVG"])
(in the generate() method, on the CMakeDeps object)
jcar87
reviewed
Dec 22, 2025
| check_min_cppstd(self, self._minimum_cpp_standard) | ||
|
|
||
| if self.options.with_svg and Version(self.version) < "4.4": | ||
| raise ConanInvalidConfiguration(f"{self.ref} with_svg option is only available for versions >= 4.4") |
Contributor
There was a problem hiding this comment.
if the option is not existent in earlier versions, we just delete the option in the config_options() method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
with_svgoption forrmlui/4.4to enable the SVG plugin (lunasvg).ENABLE_SVG_PLUGINand link againstlunasvg::lunasvgvia CMakeDeps.