-
Notifications
You must be signed in to change notification settings - Fork 2.2k
rmlui: add optional SVG plugin support #29200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| --- CMakeLists.txt | ||
| +++ CMakeLists.txt | ||
| @@ -377,14 +377,12 @@ | ||
|
|
||
| message("-- Can SVG plugin be enabled - looking for lunasvg library") | ||
|
|
||
| - find_package(lunasvg REQUIRED) | ||
| - | ||
| - list(APPEND CORE_LINK_LIBS ${LUNASVG_LIBRARIES}) | ||
| - list(APPEND CORE_INCLUDE_DIRS ${LUNASVG_INCLUDE_DIR}) | ||
| + find_package(lunasvg REQUIRED CONFIG) | ||
| + list(APPEND CORE_LINK_LIBS lunasvg::lunasvg) | ||
|
Comment on lines
+7
to
+12
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is this patch necessary? Are there errors if this patch is not included? (in the |
||
| list(APPEND CORE_PRIVATE_DEFS RMLUI_ENABLE_SVG_PLUGIN) | ||
|
|
||
| list(APPEND Core_HDR_FILES ${SVG_HDR_FILES}) | ||
| list(APPEND Core_PUB_HDR_FILES ${SVG_PUB_HDR_FILES}) | ||
| list(APPEND Core_SRC_FILES ${SVG_SRC_FILES}) | ||
|
|
||
| message("-- Can SVG plugin be enabled - yes - lunasvg library found") | ||
| endif() | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the option is not existent in earlier versions, we just delete the option in the
config_options()method