-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use vault for centos7 and remove centos6 build files #271
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Isuru! 🙏
CI was failing as the script hasn't been added. So added relevant suggestions to address below
It appears to still be picking up docker-images/linux-anvil-aarch64-cuda/Dockerfile Lines 53 to 59 in 60e5c0b
|
The script i used to get some centos stuff working again is this one Bash Script#!/bin/bash
# Define the base URL to use
BASEURL='http://vault.centos.org/centos/$releasever/os/$basearch/'
# Path to the repository file
REPO_FILE="/etc/yum.repos.d/CentOS-Base.repo"
# Backup the original repository file
cp $REPO_FILE $REPO_FILE.bak
# Function to update a repository section
update_repo_section() {
local section=$1
sed -i "/\[$section\]/,/\[/ {
s|^mirrorlist=.*|#mirrorlist=disabled|
s|^#baseurl=.*|baseurl=$BASEURL|
}" $REPO_FILE
}
# List of repository sections to update
REPO_SECTIONS=("base" "updates" "extras" "centosplus")
# Update each repository section
for section in "${REPO_SECTIONS[@]}"; do
update_repo_section $section
done
# Clean YUM cache
yum clean all
echo "Repository configuration updated. Please verify the changes in $REPO_FILE." |
Signed-off-by: Marcel Bargull <[email protected]>
Signed-off-by: Marcel Bargull <[email protected]>
Signed-off-by: Marcel Bargull <[email protected]>
Signed-off-by: Marcel Bargull <[email protected]>
Otherwise the RPM fix runs into errors to due encoding issues.
Signed-off-by: Marcel Bargull <[email protected]>
Signed-off-by: Marcel Bargull <[email protected]>
Signed-off-by: Marcel Bargull <[email protected]>
Signed-off-by: Marcel Bargull <[email protected]>
I've added |
Can we please finish reviewing before just merging? |
linux-anvil-aarch64-cuda/Dockerfile
Outdated
# Add the archived repo URL and fix RPM imports | ||
ADD centos7-x86_64-vault.repo /tmp/ | ||
ADD centos7-aarch64-vault.repo /tmp/ | ||
ADD centos7-ppc64le-vault.repo /tmp/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need all of these are can we limit to the one relevant for that architecture?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I figured that it'd be better to keep all these hacks in one place. Otherwise there are different hacks accumulating in each image. I saw three different ways of doing the same thing done in slightly different ways.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok maybe we can drop these in one directory and add that. Then cleanup anything leftover after. Have tried something like this in commit: 9e83468
Feel free to do sensible changes -- but it would be good to get working containers out rather than being meticulous about build scripts. |
Also clean them up after so they are removed final squashed image.
Ok tried to push a few changes that cleaned up a few things Happy to discuss any of them as needed Please let me know what you think 🙂 |
|
Thanks all! 🙏 |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)