[v9] Enable tests #35

traversaro · 2024-10-02T15:42:44Z

Given what we learned in conda-forge/gz-sensors-feedstock#51, we can now enable tests also here, these may be helpful to early catch errors like robotology/gz-sim-yarp-plugins#208 .

Checklist

Used a personal fork of the feedstock to propose changes
Bumped the build number (if the version is unchanged)
Reset the build number to 0 (if the version changed)
Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
Ensured the license file is being packaged.

traversaro · 2024-10-02T15:42:56Z

@conda-forge-admin, please rerender

conda-forge-admin · 2024-10-02T15:44:37Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

…nda-forge-pinning 2024.10.02.13.37.37

traversaro · 2024-10-02T17:22:43Z

On Windows are failing:

	 79 - REGRESSION_reload_engine_ogre_gl3plus (Failed)
	 81 - REGRESSION_reload_engine_ogre2_gl3plus (Failed)
	203 - UNIT_RenderingIface_TEST_ogre_gl3plus (Failed)
	205 - UNIT_RenderingIface_TEST_ogre2_gl3plus (Failed)

many more on Linux, but we still need to update the docker image. Almost all tests are also failing with a segfault on osx.

traversaro · 2024-10-02T17:24:05Z

@conda-forge-admin please rerender

…nda-forge-pinning 2024.10.02.13.37.37

traversaro · 2024-10-02T19:50:31Z

Ok, all ogre_ tests do not pass on Linux as ogre does not support EGL, so it make sense to just keep the ogre2/ogre-next tests on Linux.

traversaro · 2024-10-02T20:35:42Z

Ok, skipping _ogre_ the only failing test on Linux is:

UNIT_RenderingIface_TEST_ogre2_gl3plus

while almost all the ogre2_metal_ tests fail on macOS.

traversaro · 2024-10-02T21:16:14Z

I reproduce the failure by artificially setting DISPLAY to an empty env variable, to simulate the case in which no X server is available:

(gzrenderingdev) traversaro@IITBMP014LW012:~/gz-rendering/build$ DISPLAY= ctest -E "_ogre_" -R "Iface" -VV
UpdateCTestConfiguration  from :/home/traversaro/gz-rendering/build/DartConfiguration.tcl
Parse Config file:/home/traversaro/gz-rendering/build/DartConfiguration.tcl
UpdateCTestConfiguration  from :/home/traversaro/gz-rendering/build/DartConfiguration.tcl
Parse Config file:/home/traversaro/gz-rendering/build/DartConfiguration.tcl
Test project /home/traversaro/gz-rendering/build
Constructing a list of tests
Done constructing a list of tests
Updating test list for fixtures
Added 0 tests to meet fixture requirements
Checking test dependency graph...
Checking test dependency graph end
test 212
    Start 212: UNIT_RenderingIface_TEST_ogre2_gl3plus

212: Test command: /home/traversaro/gz-rendering/build/bin/UNIT_RenderingIface_TEST "--gtest_output=xml:/home/traversaro/gz-rendering/build/test_results/UNIT_RenderingIface_TEST_ogre2_gl3plus.xml"
212: Working Directory: /home/traversaro/gz-rendering/build/test/common_test
212: Environment variables:
212:  GZ_ENGINE_TO_TEST=ogre2
212:  GZ_ENGINE_BACKEND=gl3plus
212: Test timeout computed to be: 240
212: Running main() from /home/traversaro/gz-rendering/test/gtest_vendor/src/gtest_main.cc
212: [==========] Running 3 tests from 1 test suite.
212: [----------] Global test environment set-up.
212: [----------] 3 tests from RenderingIfaceTest
212: [ RUN      ] RenderingIfaceTest.HasEngine
212: [       OK ] RenderingIfaceTest.HasEngine (0 ms)
212: [ RUN      ] RenderingIfaceTest.GetEngine
212: (2024-10-02 23:15:34.592) [debug] [CommonRenderingTest.hh:44] Read GZ_ENGINE_TO_TEST=ogre2
212: (2024-10-02 23:15:34.592) [debug] [CommonRenderingTest.hh:47] Read GZ_ENGINE_BACKEND=gl3plus
212: (2024-10-02 23:15:34.593) [debug] [RenderingIface.cc:135] No rendering engine is loaded yet
212: envEngine ogre2
212: (2024-10-02 23:15:34.593) [info] [RenderEngineManager.cc:455] Loading plugin [gz-rendering-ogre2]
212: (2024-10-02 23:15:34.615) [warning] [Ogre2RenderEngine.cc:551] Unable to open display: . Trying to run in headless mode.
212: libEGL warning: failed to open /dev/dri/renderD128: Permission denied
212:
212: libEGL warning: failed to open /dev/dri/renderD128: Permission denied
212:
212: libEGL warning: NEEDS EXTENSION: falling back to kms_swrast
212: libEGL warning: failed to open /dev/dri/renderD128: Permission denied
212:
212: libEGL warning: failed to open /dev/dri/renderD128: Permission denied
212:
212: libEGL warning: NEEDS EXTENSION: falling back to kms_swrast
212: eng 0x7fec515934c0
212: (2024-10-02 23:15:35.178) [debug] [RenderingIface.cc:135] No rendering engine is loaded yet
212: (2024-10-02 23:15:35.178) [info] [RenderEngineManager.cc:455] Loading plugin [no_such_engine]
212: (2024-10-02 23:15:35.178) [error] [RenderEngineManager.cc:474] Failed to load plugin [no_such_engine] : couldn't find shared library.
212: (2024-10-02 23:15:35.178) [error] [RenderEngineManager.cc:227] Invalid render-engine index: 1000000
212: [       OK ] RenderingIfaceTest.GetEngine (586 ms)
212: [ RUN      ] RenderingIfaceTest.RegisterEngine
212: (2024-10-02 23:15:35.179) [info] [RenderEngineManager.cc:455] Loading plugin [gz-rendering-ogre]
212: (2024-10-02 23:15:35.195) [error] [OgreRenderEngine.cc:396] Unable to open display:
1/2 Test #212: UNIT_RenderingIface_TEST_ogre2_gl3plus .........***Exception: SegFault  0.64 sec
test 213
    Start 213: check_UNIT_RenderingIface_TEST_ogre2_gl3plus

213: Test command: /usr/bin/python3.12 "/home/traversaro/miniforge3/envs/gzrenderingdev/share/gz/gz-cmake4/tools/check_test_ran.py" "/home/traversaro/gz-rendering/build/test_results/UNIT_RenderingIface_TEST_ogre2_gl3plus.xml"
213: Working Directory: /home/traversaro/gz-rendering/build/test/common_test
213: Test timeout computed to be: 1500
213: Checking for test results in /home/traversaro/gz-rendering/build/test_results/UNIT_RenderingIface_TEST_ogre2_gl3plus.xml
2/2 Test #213: check_UNIT_RenderingIface_TEST_ogre2_gl3plus ...   Passed    0.03 sec

The following tests passed:
        check_UNIT_RenderingIface_TEST_ogre2_gl3plus

50% tests passed, 1 tests failed out of 2

Total Test time (real) =   0.68 sec

The following tests FAILED:
        212 - UNIT_RenderingIface_TEST_ogre2_gl3plus (SEGFAULT)
Errors while running CTest
Output from these tests are in: /home/traversaro/gz-rendering/build/Testing/Temporary/LastTest.log
Use "--rerun-failed --output-on-failure" to re-run the failed cases verbosely.

traversaro · 2024-10-03T07:40:41Z

Ok, skipping _ogre_ the only failing test on Linux is:
UNIT_RenderingIface_TEST_ogre2_gl3plus 
while almost all the ogre2_metal_ tests fail on macOS.

Problem reported upstream in gazebosim/gz-rendering#1072 .

traversaro · 2024-10-03T08:49:50Z

On Windows are failing:
	 79 - REGRESSION_reload_engine_ogre_gl3plus (Failed)
	 81 - REGRESSION_reload_engine_ogre2_gl3plus (Failed)
	203 - UNIT_RenderingIface_TEST_ogre_gl3plus (Failed)
	205 - UNIT_RenderingIface_TEST_ogre2_gl3plus (Failed)
many more on Linux, but we still need to update the docker image. Almost all tests are also failing with a segfault on osx.

Actually all the other tests pass a bit too fast, so I guess they are not actually testing anything.

traversaro · 2024-10-03T10:02:40Z

For future reference:

conda create -n gzrenderingdev cmake pkg-config make ninja compilers  libgz-math8 libgz-common6 libgz-plugin3 libgz-utils3 ogre-next ogre==1.10.* python

on windows:

conda install dlfcn-win32

on Linux

conda install libgl-devel libopengl-devel libegl-devel libglx-devel

traversaro · 2024-10-03T15:21:30Z

After fixing the test to actually run, the tests that are actually failing on Windows are:

         25 - INTEGRATION_gpu_rays_ogre2_gl3plus (Failed)
         35 - INTEGRATION_mesh_ogre_gl3plus (Failed)
         65 - INTEGRATION_thermal_camera_ogre2_gl3plus (Failed)

traversaro · 2024-10-03T15:29:40Z

After fixing the test to actually run, the tests that are actually failing on Windows are:
         25 - INTEGRATION_gpu_rays_ogre2_gl3plus (Failed)
         35 - INTEGRATION_mesh_ogre_gl3plus (Failed)
         65 - INTEGRATION_thermal_camera_ogre2_gl3plus (Failed)

In CI the tests are much more, let's skip Windows tests there for now.

traversaro · 2024-10-03T15:43:33Z

On osx-arm64, the tests that are not passing locally are:

	 15 - INTEGRATION_camera_ogre_gl3plus (Failed)
	 19 - INTEGRATION_depth_camera_ogre_gl3plus (Failed)
	 29 - INTEGRATION_heightmap_ogre2_metal (Failed)
	 35 - INTEGRATION_mesh_ogre_gl3plus (SEGFAULT)
	159 - UNIT_Material_TEST_ogre_gl3plus (Failed)
	199 - UNIT_RenderEngine_TEST_ogre_gl3plus (Failed)

traversaro · 2024-10-03T15:55:06Z

On osx-arm64, the tests that are not passing locally are:

	 15 - INTEGRATION_camera_ogre_gl3plus (Failed)
	 19 - INTEGRATION_depth_camera_ogre_gl3plus (Failed)
	 29 - INTEGRATION_heightmap_ogre2_metal (Failed)
	 35 - INTEGRATION_mesh_ogre_gl3plus (SEGFAULT)
	159 - UNIT_Material_TEST_ogre_gl3plus (Failed)
	199 - UNIT_RenderEngine_TEST_ogre_gl3plus (Failed)

The only one related to ogre2 is INTEGRATION_heightmap_ogre2_metal, I do not think this explains the failures in robotology/gz-sim-yarp-plugins#208 .

traversaro · 2024-10-03T20:30:36Z

We enabled some tests. macOS and Windows are still disabled, but better then nothing.

Enable tests

186ca6b

traversaro requested a review from wolfv as a code owner October 2, 2024 15:42

MNT: Re-rendered with conda-build 24.9.0, conda-smithy 3.41.1, and co…

0473459

…nda-forge-pinning 2024.10.02.13.37.37

Create conda_build_config.yaml

3229ed4

traversaro changed the title ~~Enable tests~~ [v9] Enable tests Oct 2, 2024

MNT: Re-rendered with conda-build 24.9.0, conda-smithy 3.41.1, and co…

8b37329

…nda-forge-pinning 2024.10.02.13.37.37

Update build_cxx.sh

5b7846f

Update build_cxx.sh

22eb052

traversaro mentioned this pull request Oct 3, 2024

[v8] Enable tests #36

Closed

5 tasks

traversaro added 2 commits October 3, 2024 16:50

Create 1073.patch

3af298a

Add 1073 patch

d089d08

traversaro added 3 commits October 3, 2024 17:56

Update build_cxx.sh

222cd4e

Update build_cxx.sh

6c8945a

Update bld_cxx.bat

6963db2

traversaro merged commit c9d0439 into conda-forge:main Oct 3, 2024
8 checks passed

traversaro mentioned this pull request Oct 21, 2024

Stop using CDTs for OpenGL and run render test when Python tests are run conda-forge/mujoco-feedstock#66

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[v9] Enable tests #35

[v9] Enable tests #35

traversaro commented Oct 2, 2024 •

edited

Loading

traversaro commented Oct 2, 2024

conda-forge-admin commented Oct 2, 2024

traversaro commented Oct 2, 2024

traversaro commented Oct 2, 2024

traversaro commented Oct 2, 2024

traversaro commented Oct 2, 2024

traversaro commented Oct 2, 2024

traversaro commented Oct 3, 2024

traversaro commented Oct 3, 2024

traversaro commented Oct 3, 2024 •

edited

Loading

traversaro commented Oct 3, 2024

traversaro commented Oct 3, 2024

traversaro commented Oct 3, 2024

traversaro commented Oct 3, 2024

traversaro commented Oct 3, 2024

[v9] Enable tests #35

[v9] Enable tests #35

Conversation

traversaro commented Oct 2, 2024 • edited Loading

traversaro commented Oct 2, 2024

conda-forge-admin commented Oct 2, 2024

traversaro commented Oct 2, 2024

traversaro commented Oct 2, 2024

traversaro commented Oct 2, 2024

traversaro commented Oct 2, 2024

traversaro commented Oct 2, 2024

traversaro commented Oct 3, 2024

traversaro commented Oct 3, 2024

traversaro commented Oct 3, 2024 • edited Loading

traversaro commented Oct 3, 2024

traversaro commented Oct 3, 2024

traversaro commented Oct 3, 2024

traversaro commented Oct 3, 2024

traversaro commented Oct 3, 2024

traversaro commented Oct 2, 2024 •

edited

Loading

traversaro commented Oct 3, 2024 •

edited

Loading