Skip to content

Pin PyNVML to 11, enable Grayskull for version updates, add pip check & apply CFEP-25 #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Mar 11, 2025

Conversation

jakirkham
Copy link
Member

@jakirkham jakirkham commented Mar 4, 2025

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Fixes #23
Fixes #24
Closes #21

regro-cf-autotick-bot and others added 11 commits January 8, 2025 08:04
Bots typically resort the keys. So go ahead and do that now to avoid
churn.
When the bot makes version updates, use Grayskull to update
dependencies.
These packages are only needed at runtime. So drop them from the build.
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@jakirkham jakirkham mentioned this pull request Mar 4, 2025
3 tasks
@jakirkham
Copy link
Member Author

Also synchronizing these changes with upstream via PR: rapidsai/jupyterlab-nvdashboard#220

Will update that further based on review feedback here

@jakirkham
Copy link
Member Author

@jacobtomlinson could you please review?

Make it easier to find & change the `number`.
@jakirkham
Copy link
Member Author

Please let me know if anything else is needed here. Otherwise this should be good to go

@jacobtomlinson jacobtomlinson merged commit 3e0c691 into conda-forge:main Mar 11, 2025
5 checks passed
@jakirkham jakirkham deleted the pin_pynvml_11 branch March 11, 2025 15:33
@jakirkham
Copy link
Member Author

Thanks Jacob! 🙏

@jakirkham jakirkham mentioned this pull request Mar 11, 2025
3 tasks
@jakirkham
Copy link
Member Author

Have pushed some additional cleanup changes upstream: rapidsai/jupyterlab-nvdashboard#224

These follow a DRY model to ensure better package metadata alignment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider using Grayskull and pip check to update/validate dependencies Adding PyNVML pin
4 participants