Sync recipe with conda-forge #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
This needs to be handled differently for Conda. So split out the handling of this dependency.
jakirkham
commented
Mar 11, 2025
Comment on lines
79
to
+90
| test_python: | ||
| common: | ||
| - output_types: [conda, requirements, pyproject] | ||
| packages: | ||
| - pytest | ||
| - pytest-jupyter[server]>=0.6.0 | ||
| - pytest-asyncio | ||
| - websockets | ||
| - output_types: [requirements, pyproject] | ||
| packages: | ||
| - pytest-jupyter[server]>=0.6.0 | ||
| - output_types: [conda] | ||
| packages: | ||
| - pytest-jupyter-server>=0.6.0 |
There was a problem hiding this comment.
Conda doesn't handle the extra syntax [...]. So adapt this for Conda
Also align package metadata.
jacobtomlinson
approved these changes
Mar 11, 2025
bdice
approved these changes
Mar 11, 2025
AjayThorve
approved these changes
Mar 11, 2025
|
Thanks all! 🙏 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syncs the recipe here with the one in conda-forge.
xref: conda-forge/jupyterlab-nvdashboard-feedstock#25