-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid undefined jinja errors for skipped recipes #5458
Conversation
68f96ec
to
3275a7b
Compare
CodSpeed Performance ReportMerging #5458 will not alter performanceComparing Summary
|
Thanks Michael! 🙏 If it is helpful, here is a generic example ( conda-forge/conda-smithy#2011 ) |
3275a7b
to
c509bbb
Compare
c509bbb
to
6f1c010
Compare
Thanks Michael! 🙏 Looks like this is passes Canary builds fail, but those are pointing out deprecations in other tests. Think we can safely ignore those here |
@kenodegard could you please take a look as well? 🙂 |
The tests are blocked by conda/conda#14169 |
Thanks Bianca and Ken! 🙏 |
macOS tests are failing due to #5470 |
Thanks for sticking with this through the slog, @beeankha and @kenodegard |
Description
A few NVIDIA feedstocks on conda-forge have been failing to re-render lately. See conda-forge/cuda-nvdisasm-feedstock#12. The expected behavior was that undefined jinja variables shouldn't error out when the metadata is skipped.
I tracked it back to #5371, which I think is a good code improvement. In order to avoid these irrelevant errors for skipped recipes, we just abort after the first parsing pass.
Checklist - did you ...
news
directory (using the template) for the next release's release notes?Add / update outdated documentation?