-
Notifications
You must be signed in to change notification settings - Fork 26
fix: remove child dependency inflight [EXT-6447] #2530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove child dependency inflight [EXT-6447] #2530
Conversation
b76b1e0
to
ebe78bf
Compare
@@ -47,5 +47,9 @@ | |||
}, | |||
"dependencies": { | |||
"open": "^10.1.0" | |||
}, | |||
"overrides": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is ok, but I don't see tiged in the deps here? Is the assumption tiged is transitive on one our dependencies? If so, does the offending version of our dep have a sec vuln patch available?
@@ -48,6 +48,11 @@ | |||
"tildify": "2.0.0", | |||
"validate-npm-package-name": "6.0.1" | |||
}, | |||
"overrides": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we not bump tiged here instead?
@@ -52,5 +52,9 @@ | |||
"dependencies": { | |||
"contentful-management": ">=7.30.0" | |||
}, | |||
"overrides": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here, do we know the dep here that is offending?
Add redundant space to random comments in each package so that lerna will release.
ebe78bf
to
4c46300
Compare
The following dependency chain is causing vulnerabilities because inflight is deprecated and unstable:
tiged -> rimraf -> glob -> inflight.
Glob version > 9 deprecates inflight, rimraf version 5 uses glob v10.
Had a similar change last week, as the issue was occurring in app-scripts. However, since the app-scripts version comes bundled with all the other packages (which had tiged OR rimraf < v5 OR another package in the repo as a dependency) we needed to update all packages in the repo to override rimraf.
In order to allow lerna to release, I made small adjustments to a few comments.