Skip to content

fix: remove child dependency inflight [EXT-6447] #2530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025
Merged

fix: remove child dependency inflight [EXT-6447] #2530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
317 changes: 6 additions & 311 deletions package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 4 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,5 +47,9 @@
},
"dependencies": {
"open": "^10.1.0"
},
"overrides": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is ok, but I don't see tiged in the deps here? Is the assumption tiged is transitive on one our dependencies? If so, does the offending version of our dep have a sec vuln patch available?

"rimraf": "^5.0.0",
"glob": "^10.0.0"
}
}
2 changes: 1 addition & 1 deletion packages/contentful--app-scripts/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ export function getFunctionsFromManifest(): Omit<ContentfulFunction, 'entryFile'
process.exit(1);
}

// EntryFile is not used but we do want to strip it
// EntryFile is not used but we do want to strip it
// eslint-disable-next-line no-unused-vars
const { entryFile: _, ...itemWithoutEntryFile } = item;

Expand Down
93 changes: 0 additions & 93 deletions packages/contentful--create-contentful-app/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions packages/contentful--create-contentful-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,11 @@
"tildify": "2.0.0",
"validate-npm-package-name": "6.0.1"
},
"overrides": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we not bump tiged here instead?

"tiged": {
"rimraf": "^5.0.0"
}
},
"bugs": {
"url": "https://github.com/contentful/create-contentful-app/issues"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/contentful--create-contentful-app/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ async function initProject(appName: string, options: CLIOptions) {

if (!isInteractive && isContentfulTemplate(templateSource) && normalizedOptions.function) {
// If function flag is specified, but no function name is provided, we default to external-references
// for legacy support
// for legacy support
if (normalizedOptions.function === true) {
normalizedOptions.function = 'external-references';
}
Expand Down
Loading