Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix libavif build on VS2019 syntax error #649

Merged
merged 3 commits into from
Mar 14, 2025

Conversation

crazywhalecc
Copy link
Owner

@crazywhalecc crazywhalecc commented Mar 14, 2025

What does this PR do?

Created upstream issue: AOMediaCodec/libavif#2686, and fix #648

Checklist before merging

If your PR involves the changes mentioned below and completed the action, please tick the corresponding option.
If a modification is not involved, please skip it directly.

  • If you modified *.php, run composer cs-fix at local machine.
  • If it's an extension or dependency update, make sure adding related extensions in src/global/test-extensions.php.
  • If you changed the behavior of static-php-cli, update docs in ./docs/.
  • If you updated config/xxx.json content, run bin/spc dev:sort-config xxx.

Sorry, something went wrong.

@crazywhalecc crazywhalecc changed the title Test old source of libavif Fix libavif build on VS2019 syntax error Mar 14, 2025
@crazywhalecc crazywhalecc added bug Something isn't working kind/dependency Issues related to dependencies os/windows Things only for Windows labels Mar 14, 2025
@crazywhalecc crazywhalecc merged commit 4558204 into main Mar 14, 2025
8 checks passed
@crazywhalecc crazywhalecc deleted the fix/libavif-windows-build branch March 14, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working kind/dependency Issues related to dependencies os/windows Things only for Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

libavif on windows build failed
2 participants