Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix libavif build on VS2019 syntax error #649

Merged
merged 3 commits into from
Mar 14, 2025
Merged

Fix libavif build on VS2019 syntax error #649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0d53015
Test old source of libavif
crazywhalecc Mar 14, 2025
cc73ab9
Test old source of libavif
crazywhalecc Mar 14, 2025
bd2e085
Fix libavif 1.2.0 bug
crazywhalecc Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/SPC/builder/windows/library/libavif.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ class libavif extends WindowsLibraryBase

protected function build(): void
{
// workaround for libavif 1.2.0 bug
FileSystem::replaceFileStr($this->source_dir . '\src\read.c', 'avifFileType ftyp = {};', 'avifFileType ftyp = { 0 };');
// reset cmake
FileSystem::resetDir($this->source_dir . '\build');

Expand Down
17 changes: 9 additions & 8 deletions src/globals/test-extensions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,17 +14,18 @@
// test php version
$test_php_version = [
'8.1',
'8.2',
'8.3',
// '8.2',
// '8.3',
'8.4',
];

// test os (macos-13, macos-14, ubuntu-latest, windows-latest are available)
$test_os = [
'macos-13',
'macos-14',
'ubuntu-latest',
// 'windows-latest',
// 'macos-13',
// 'macos-14',
// 'ubuntu-latest',
'windows-2019',
'windows-latest',
];

// whether enable thread safe
Expand All @@ -41,13 +42,13 @@
// If you want to test your added extensions and libs, add below (comma separated, example `bcmath,openssl`).
$extensions = match (PHP_OS_FAMILY) {
'Linux', 'Darwin' => 'gettext',
'Windows' => 'bcmath',
'Windows' => 'gd',
};

// If you want to test lib-suggests feature with extension, add them below (comma separated, example `libwebp,libavif`).
$with_libs = match (PHP_OS_FAMILY) {
'Linux', 'Darwin' => '',
'Windows' => '',
'Windows' => 'libavif',
};

// Please change your test base combination. We recommend testing with `common`.
Expand Down