Bump urllib3 from 1.26.16 to 1.26.17 #326
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [urllib3](https://github.com/urllib3/urllib3) from 1.26.16 to 1.26.17. - [Release notes](https://github.com/urllib3/urllib3/releases) - [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst) - [Commits](urllib3/urllib3@1.26.16...1.26.17) --- updated-dependencies: - dependency-name: urllib3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #326 +/- ##
=======================================
Coverage 95.40% 95.40%
=======================================
Files 56 56
Lines 3134 3134
=======================================
Hits 2990 2990
Misses 144 144
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@d33bs - tagging you for review when you get a chance. Are there other files to update besides |
There was a problem hiding this comment.
Thanks @gwaybio - I think this looks good to me. The tests are passing and the poetry.lock file update will hopefully help resolve possible dependency resolution issues which could come up (in addition to the version preference from source-based installs).
I looked at where this dependency comes from using the following:
# command to show the dependency information from poetry
$ poetry show urllib3
name : urllib3
version : 1.26.17
description : HTTP library with thread-safe connection pooling, file post, and more.
required by
- botocore >=1.25.4,<1.27
- requests >=1.21.1,<3Seeing this made me wonder if we could update botocore (or boto3, s3fs etc) as urllib3>=2.x is available. I gave this a quick try and found I was still at urllib3=1.26.17, making me think there might be reason for not progressing past this version of urllib3 yet. That said, I think it'd be fine to move forward as-is.
|
Sounds good! I will go ahead and merge |
Bumps urllib3 from 1.26.16 to 1.26.17.
Release notes
Sourced from urllib3's releases.
Changelog
Sourced from urllib3's changelog.
Commits
c9016bfRelease 1.26.170122035Backport GHSA-v845-jxx5-vc9f (#3139)e63989fFix installingbrotliextra on Python 2.72e7a24d[1.26] Configure OS for RTD to fix building docs57181d6[1.26] Improve error message when calling urllib3.request() (#3058)3c01480[1.26] Run coverage even with failed jobsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.