-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refactor integration pipeline and add poetry-dynamic-versioning support #342
feat: refactor integration pipeline and add poetry-dynamic-versioning support #342
Conversation
d78065a
to
b34d772
Compare
Codecov Report
@@ Coverage Diff @@
## main #342 +/- ##
==========================================
+ Coverage 95.40% 95.62% +0.22%
==========================================
Files 56 56
Lines 3135 3135
==========================================
+ Hits 2991 2998 +7
+ Misses 144 137 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! I added a few comments and overall wasn't sure about moving forward just yet without further input on this PR. Please don't hesitate to let me know if you have any questions.
6ba4a7e
to
4e06898
Compare
7b7b533
to
c57d921
Compare
- refactor: revise testing into unified integration pipeline - refactor: create re-usable setup-env action - feat: add pipeline support for poetry dynamic versioning - feat: add actionlint to pre-commit hooks.
c57d921
to
85e9666
Compare
@d33bs This is ready for re-review. It contains a pretty substantial re-write from the last version, but I managed to make the workflow a lot more DRY by creating a I think I also took into account all your suggestions and added more documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appreciate your replies and great effort towards both documentation and improving the work! LGTM.
The command sha258sum works on ubuntu-latest runners, but not macOS runners. Switching to shasum -a 256 works for both.
Description
This introduces streamlined github actions pipelines are modeled after this ci pipeline.
They also include changes needed to support poetry-dynamic-versioning for the build and release process.
This PR is intended to be integrated after #341
What is the nature of your change?
Checklist
Please ensure that all boxes are checked before indicating that a pull request is ready for review.