Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor integration pipeline and add poetry-dynamic-versioning support #342

Merged
merged 3 commits into from
Oct 29, 2023

Conversation

kenibrewer
Copy link
Member

@kenibrewer kenibrewer commented Oct 27, 2023

Description

This introduces streamlined github actions pipelines are modeled after this ci pipeline.
They also include changes needed to support poetry-dynamic-versioning for the build and release process.

This PR is intended to be integrated after #341

What is the nature of your change?

  • Bug fix (fixes an issue).

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have deleted all non-relevant text in this pull request template.

@kenibrewer kenibrewer force-pushed the feat/ci-release-actions branch from d78065a to b34d772 Compare October 27, 2023 18:59
@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2023

Codecov Report

Merging #342 (0e6aaa5) into main (7b97db7) will increase coverage by 0.22%.
Report is 6 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #342      +/-   ##
==========================================
+ Coverage   95.40%   95.62%   +0.22%     
==========================================
  Files          56       56              
  Lines        3135     3135              
==========================================
+ Hits         2991     2998       +7     
+ Misses        144      137       -7     
Flag Coverage Δ
unittests 95.62% <ø> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pycytominer/consensus.py 100.00% <ø> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kenibrewer kenibrewer marked this pull request as ready for review October 27, 2023 19:09
@kenibrewer kenibrewer requested a review from d33bs October 27, 2023 19:09
Copy link
Member

@d33bs d33bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! I added a few comments and overall wasn't sure about moving forward just yet without further input on this PR. Please don't hesitate to let me know if you have any questions.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/pytest.yml Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/codecov.yml Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@kenibrewer kenibrewer force-pushed the feat/ci-release-actions branch 4 times, most recently from 6ba4a7e to 4e06898 Compare October 28, 2023 18:34
@kenibrewer kenibrewer marked this pull request as draft October 28, 2023 18:34
@kenibrewer kenibrewer force-pushed the feat/ci-release-actions branch 5 times, most recently from 7b7b533 to c57d921 Compare October 28, 2023 18:51
- refactor: revise testing into unified integration pipeline
- refactor: create re-usable setup-env action
- feat: add pipeline support for poetry dynamic versioning
- feat: add actionlint to pre-commit hooks.
@kenibrewer kenibrewer force-pushed the feat/ci-release-actions branch from c57d921 to 85e9666 Compare October 28, 2023 18:57
@kenibrewer kenibrewer marked this pull request as ready for review October 28, 2023 18:59
@kenibrewer
Copy link
Member Author

@d33bs This is ready for re-review. It contains a pretty substantial re-write from the last version, but I managed to make the workflow a lot more DRY by creating a setup-env re-usable action to help configure the environment for all the other jobs.

I think I also took into account all your suggestions and added more documentation.

@kenibrewer kenibrewer requested a review from d33bs October 28, 2023 19:01
@kenibrewer kenibrewer self-assigned this Oct 28, 2023
@kenibrewer kenibrewer changed the title Feat/ci release actions feat: refactor integration pipeline and add poetry-dynamic-versioning support Oct 28, 2023
Copy link
Member

@d33bs d33bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate your replies and great effort towards both documentation and improving the work! LGTM.

.github/actions/setup-env/action.yaml Outdated Show resolved Hide resolved
pycytominer/consensus.py Show resolved Hide resolved
The command sha258sum works on ubuntu-latest runners, but not macOS runners. Switching to shasum -a 256 works for both.
@kenibrewer kenibrewer merged commit ea789ba into cytomining:main Oct 29, 2023
9 checks passed
@kenibrewer kenibrewer deleted the feat/ci-release-actions branch October 29, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants