Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for Python 3.12 #474

Closed
wants to merge 2 commits into from
Closed

Updates for Python 3.12 #474

wants to merge 2 commits into from

Conversation

d33bs
Copy link
Member

@d33bs d33bs commented Nov 3, 2024

Description

This PR focuses on adding updates which enable compatibility with Python 3.12. I found that we needed to update Numpy and Pandas, which in turn required updates for database querying through Pandas and SQLAlchemy, whose API has changed. This resulted in some changes to test_cells. Eventually I found that test_collate fails due to the database API shifts from cytominer-database (which would require outside updates we're unable to make directly).

It might be that we consider Python 3.12 support alongside dropping collate support. Otherwise we may need to update cytominer-database to provide compatibility. On a related note, I found there were various issues which might need to be solved but I've proposed sidestepping in #473 by relying on cytominer-database==v0.3.4.

What is the nature of your change?

  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

📚 Documentation preview 📚: https://pycytominer--474.org.readthedocs.build/en/474/

@d33bs
Copy link
Member Author

d33bs commented Nov 5, 2024

Closing this as I feel it might have been an incorrect attempt in the midst of the dependency changes.

@d33bs d33bs closed this Nov 5, 2024
@d33bs d33bs deleted the python-312 branch November 5, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant