Clip polygon #124
Closed
Clip polygon #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if the projection is using antimeridian clipping, use that also for the sphereStream if the projection is using angle clipping, use 180 (i.e. no clipping) for the sphere stream
|
For the record 3df20ab#diff-17e3641b0cc55c3ac139841ba77aa058L109 was necessary to avoid this: and this: and this: |
…er to fix the precision to 1 for polyhedral projections (after all we're just drawing a straight line in any case) https://gateway.ipfs.io/ipfs/QmZdXgR4wEosW1Ues3ZcfcDBJP1pnKSeErgz4fkVVJbntq/2017-08/artifact-lee-projection-precision.png
|
This clipPolygon branch works, but it is a bit messy, and will need in any case to be complemented with the complex branch. (Complex introduces the Cox (equilateral triangle) and Lee (conformal tetrahedral) projections.) I separated the two needs while developing, but Lee's North aspect needs clipPolygon to work. So, instead of maintaining three branches (clipPolygon, complex, and a merge of them), I think I'd like to PR a unique (& cleanly rebased) branch. This also needs to settle on d3-geo's API design for clipPolygon(). |
… centroids — solves a lot of the issues at d3/d3-geo#108 (comment) and allows to use clipPolygon() properly on all polyhedral projections (tested to this date).
Fil
added a commit
to d3/d3-geo-polygon
that referenced
this pull request
Sep 19, 2017
|
This is now living in https://github.com/d3/d3-geo-polygon |
Fil
added a commit
that referenced
this pull request
Oct 1, 2017
Note that d3-geo-polygon is still unstable. When we stream points that belong to the clipping polygon itself, it sometimes bleeds out -- for example on the Waterman projection with a default aspect -- rotate [0,0]). I have been as conservative as possible: d3-geo-projection works as usual without d3-geo-polygon, and checks that it has projection.preclip (d3-geo > 1.8.1). Examples and issues at [d3-geo-polygon](https://github.com/d3/d3-geo-polygon) Solves #129 Solves #124 Solves d3/d3-geo#108 Solves #86
Fil
added a commit
that referenced
this pull request
Feb 20, 2018
Note that d3-geo-polygon is still unstable. When we stream points that belong to the clipping polygon itself, it sometimes bleeds out -- for example on the Waterman projection with a default aspect -- rotate [0,0]). I have been as conservative as possible: d3-geo-projection works as usual without d3-geo-polygon, and checks that it has projection.preclip (d3-geo > 1.8.1). Examples and issues at [d3-geo-polygon](https://github.com/d3/d3-geo-polygon) Solves #129 Solves #124 Solves d3/d3-geo#108 Solves #86
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
polyhedral uses projection.clipPolygon() if present (d3/d3-geo#108).
This will allow building "maps in a cube" (#86).
We can optionally remove this test once d3-geo has clipPolygon.