[Python] Add acceptance tests #2493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
reviewed
Mar 14, 2025
| @@ -0,0 +1,3 @@ | |||
| trace uv run --with databricks-bundles==0.7.2 -q $CLI bundle validate --output json | |||
There was a problem hiding this comment.
why does this install the package from PyPI and not from local repo?
There was a problem hiding this comment.
local package doesn't contain all necessary code yet
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
kanterov
requested review from
pietern,
andrewnester and
shreyas-goenka
as code owners
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
reviewed
Mar 17, 2025
kanterov
force-pushed
the
python-acceptance-tests
branch
from
4045d19 to
c56be44
Compare
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
This was referenced Mar 17, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 18, 2025
## Changes Fix issues with multiple resource loaders. Previously, we discarded outputs of all loaders except the last one. That worked well if there is only a single resource loader. ## Tests - Unit tests - Acceptance tests in #2493
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 18, 2025
## Changes Fix issues with bundles using multiple mutators. Previously, we didn't correctly chain output between them. ## Tests - Unit tests - Acceptance tests in #2493
There was a problem hiding this comment.
Pull Request Overview
This pull request adds acceptance tests for experimental Python integrations. It introduces tests for variable resolution, job mutators, and resource loading, and updates the corresponding configuration files.
- Adds acceptance tests in resolve-variable, mutator-ordering, resource-loading, and a test configuration file.
- Updates databricks.yml files to configure mutators, resources, and bundle settings.
Reviewed Changes
Copilot reviewed 7 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| acceptance/bundle/python/resolve-variable/resources.py | Defines acceptance tests for variable resolution with various types including complex variables |
| acceptance/bundle/python/mutator-ordering/mutators.py | Implements job mutators to append tasks to a job |
| acceptance/bundle/python/resource-loading/resources.py | Provides resource loading tests using dictionary configs |
| acceptance/bundle/python/mutator-ordering/databricks.yml | Configures the order of Python mutators and sync options |
| acceptance/bundle/python/resource-loading/databricks.yml | Sets up resource configuration for resource-loading tests |
| acceptance/bundle/python/resolve-variable/databricks.yml | Specifies variable defaults and resource configuration for variable resolution tests |
| acceptance/bundle/python/test.toml | Test configuration toggling local and cloud environments |
Files not reviewed (6)
- acceptance/bundle/python/mutator-ordering/output.txt: Language not supported
- acceptance/bundle/python/mutator-ordering/script: Language not supported
- acceptance/bundle/python/resolve-variable/output.txt: Language not supported
- acceptance/bundle/python/resolve-variable/script: Language not supported
- acceptance/bundle/python/resource-loading/output.txt: Language not supported
- acceptance/bundle/python/resource-loading/script: Language not supported
Comments suppressed due to low confidence (1)
acceptance/bundle/python/resolve-variable/resources.py:55
- The job name is set to the unresolved variable 'Variables.string_variable'. Consider using bundle.resolve_variable(Variables.string_variable) to pass the actual string value.
name=Variables.string_variable,
pietern
approved these changes
Mar 20, 2025
|
Oh nice, we can outsource all nitpicks to Copilot |
Co-authored-by: Copilot <[email protected]>
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add acceptance tests for experimental/python